Use --disable-es3-apis when running WebGL tests on the passthrough cmd decoder.

Use --disable-es3-apis when running WebGL tests on the passthrough cmd decoder.

Chrome always creates ES3 contexts which cause some WebGL validation
failures.  Disable ES3 contexts so that WebGL 1 testing works as expected
until the GL bindings are refactored.

BUG=668223
BUG=671217
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2621163007
Cr-Commit-Position: refs/heads/master@{#443705}
Committed: https://chromium.googlesource.com/chromium/src/+/1bf1c346a7c2967e70d05d2c93f1d33775482bff

[Geoff Lang, 2017-01-11 21:06:10]

Description was changed from

==========
Use --disable-es3-apis when running WebGL tests on the passthrough cmd decoder.

Chrome always creates ES3 contexts which cause some WebGL validation
failures.  Disable ES3 contexts so that WebGL 1 testing works as expected
until the GL bindings are refactored.

BUG=668223
BUG=671217
==========

to

==========
Use --disable-es3-apis when running WebGL tests on the passthrough cmd decoder.

Chrome always creates ES3 contexts which cause some WebGL validation
failures.  Disable ES3 contexts so that WebGL 1 testing works as expected
until the GL bindings are refactored.

BUG=668223
BUG=671217
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[Geoff Lang, 2017-01-11 21:07:54]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 21:08:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 21:41:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 21:41:23]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Geoff Lang, 2017-01-12 15:52:37]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 15:53:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Geoff Lang, 2017-01-12 16:38:56]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 16:39:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Geoff Lang, 2017-01-12 16:40:45]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 16:41:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Geoff Lang, 2017-01-12 17:46:35]

Description was changed from

==========
Use --disable-es3-apis when running WebGL tests on the passthrough cmd decoder.

Chrome always creates ES3 contexts which cause some WebGL validation
failures.  Disable ES3 contexts so that WebGL 1 testing works as expected
until the GL bindings are refactored.

BUG=668223
BUG=671217
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Use --disable-es3-apis when running WebGL tests on the passthrough cmd decoder.

Chrome always creates ES3 contexts which cause some WebGL validation
failures.  Disable ES3 contexts so that WebGL 1 testing works as expected
until the GL bindings are refactored.

BUG=668223
BUG=671217
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[Geoff Lang, 2017-01-12 17:46:35]

geofflang@chromium.org changed reviewers:
+ kbr@chromium.org

[Geoff Lang, 2017-01-12 17:46:47]

PTAL

[commit-bot: I haz the power, 2017-01-12 18:03:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 18:03:27]

Dry run: This issue passed the CQ dry run.

[Ken Russell (switch to Gerrit), 2017-01-13 04:52:58]

LGTM

Sorry for the delay; please feel free to ask others like zmo@ for reviews on CLs
like these.

I suspect you'll need to rebase and re-run generate_buildbot_json.py. There have
been quite a few changes over the past few days.

[Geoff Lang, 2017-01-13 16:11:43]

The CQ bit was checked by geofflang@chromium.org

[Geoff Lang, 2017-01-13 16:11:43]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2621163007/#ps80001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-01-13 16:12:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 16:59:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 16:59:35]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Geoff Lang, 2017-01-13 18:54:21]

The CQ bit was checked by geofflang@chromium.org

[commit-bot: I haz the power, 2017-01-13 18:55:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 21:19:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 21:19:21]

Failed to apply patch for content/test/gpu/generate_buildbot_json.py:
While running git apply --index -p1;
  error: patch failed: content/test/gpu/generate_buildbot_json.py:1331
  error: content/test/gpu/generate_buildbot_json.py: patch does not apply

Patch:       content/test/gpu/generate_buildbot_json.py
Index: content/test/gpu/generate_buildbot_json.py
diff --git a/content/test/gpu/generate_buildbot_json.py
b/content/test/gpu/generate_buildbot_json.py
index
48e817708036675445e381b242a1f741cdc8eb01..0893f5e55089a689add75b3db5a497780435aece
100755
--- a/content/test/gpu/generate_buildbot_json.py
+++ b/content/test/gpu/generate_buildbot_json.py
@@ -1331,6 +1331,12 @@ TELEMETRY_GPU_INTEGRATION_TESTS = {
     'extra_browser_args': [
       '--use-angle=d3d11',
       '--use-passthrough-cmd-decoder',
+      # TODO(geofflang): Remove --disable-es3-apis once crbug.com/671217 is
+      # complete.
+      '--disable-es3-apis',
+      # TODO(geofflang): --disable-es3-gl-context is required because of
+      # crbug.com/680522
+      '--disable-es3-gl-context',
     ],
   },
   'webgl2_conformance_tests': {

[Geoff Lang, 2017-01-13 21:25:00]

The CQ bit was checked by geofflang@chromium.org

[Geoff Lang, 2017-01-13 21:25:00]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2621163007/#ps100001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-01-13 21:25:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 22:39:18]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484342700084400,
"parent_rev": "1e77b2481f43cdf4b0b306ccbd2a65a613018874", "commit_rev":
"1bf1c346a7c2967e70d05d2c93f1d33775482bff"}

[commit-bot: I haz the power, 2017-01-13 22:39:45]

Description was changed from

==========
Use --disable-es3-apis when running WebGL tests on the passthrough cmd decoder.

Chrome always creates ES3 contexts which cause some WebGL validation
failures.  Disable ES3 contexts so that WebGL 1 testing works as expected
until the GL bindings are refactored.

BUG=668223
BUG=671217
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Use --disable-es3-apis when running WebGL tests on the passthrough cmd decoder.

Chrome always creates ES3 contexts which cause some WebGL validation
failures.  Disable ES3 contexts so that WebGL 1 testing works as expected
until the GL bindings are refactored.

BUG=668223
BUG=671217
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2621163007
Cr-Commit-Position: refs/heads/master@{#443705}
Committed:
https://chromium.googlesource.com/chromium/src/+/1bf1c346a7c2967e70d05d2c93f1...
==========

[commit-bot: I haz the power, 2017-01-13 22:39:47]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/1bf1c346a7c2967e70d05d2c93f1...