Add the beginning of a simple window manager that we'll support on Windows.

Add the beginning of a simple window manager that we'll support on Windows.

You can now run an alternative window manager from mash_session, mash_init etc by passing --window-manager=<name_of_wm>

R=sky@chromium.org

Committed: https://crrev.com/f620093a36270014a1964979906a47e672f16c4d
Cr-Commit-Position: refs/heads/master@{#435648}

[Ben Goodger (Google), 2016-11-17 20:14:14]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 20:15:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 20:26:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 20:26:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Ben Goodger (Google), 2016-11-17 20:30:40]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 20:33:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-11-17 20:41:58]

https://codereview.chromium.org/2511233002/diff/20001/mash/wm/wm.h
File mash/wm/wm.h (right):

https://codereview.chromium.org/2511233002/diff/20001/mash/wm/wm.h#newcode19
mash/wm/wm.h:19: class WM : public service_manager::Service,
Could I convince you to go with a more specific name? It gets confusing to talk
with people when we use the same name. Maybe TrivialWM?

[commit-bot: I haz the power, 2016-11-17 21:45:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 21:45:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-11-30 21:08:58]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 21:09:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2016-11-30 21:09:32]

OK let's try again!

[Ben Goodger (Google), 2016-11-30 21:10:31]

Description was changed from

==========
Add the beginning of a simple window manager that we'll support on Windows.

R=sky@chromium.org
==========

to

==========
Add the beginning of a simple window manager that we'll support on Windows.

You can now run an alternative window manager from mash_session, mash_init etc
by passing --window-manager=<name_of_wm>

R=sky@chromium.org
==========

[Ben Goodger (Google), 2016-11-30 21:12:32]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 21:13:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 21:18:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 21:18:07]

Dry run: Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/blimp_linux_dbg...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-11-30 21:25:46]

https://codereview.chromium.org/2511233002/diff/120001/mash/simple_wm/manifes...
File mash/simple_wm/manifest.json (right):

https://codereview.chromium.org/2511233002/diff/120001/mash/simple_wm/manifes...
mash/simple_wm/manifest.json:8: "ui": [ "ui:window_manager", "ui:gpu_client" ]
You shouldn't need ui:gpu_client (ui:window_manager includes gpu_client).

https://codereview.chromium.org/2511233002/diff/120001/mash/simple_wm/simple_...
File mash/simple_wm/simple_wm.cc (right):

https://codereview.chromium.org/2511233002/diff/120001/mash/simple_wm/simple_...
mash/simple_wm/simple_wm.cc:53: client_window_->SetBounds(GetLocalBounds());
Don't you want to offset the bounds by the title?
Generally you should use OnWmSetClientArea here, but as this is a simple wm it
doesn't really matter.

https://codereview.chromium.org/2511233002/diff/120001/mash/simple_wm/simple_...
mash/simple_wm/simple_wm.cc:168: new views::NativeWidgetAura(frame_widget);
You should pass in an additional parameter of true here to indicate the
NativeWidgetAura is for the window manager.

https://codereview.chromium.org/2511233002/diff/120001/mash/simple_wm/simple_...
mash/simple_wm/simple_wm.cc:169: views::Widget::InitParams
params(views::Widget::InitParams::TYPE_CONTROL);
Don't you want TYPE_WINDOW?

[Ben Goodger (Google), 2016-11-30 21:27:13]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 21:27:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 21:49:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 21:49:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-12-01 00:06:20]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 00:06:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2016-12-01 00:07:05]

Updated, PTAL

[sky, 2016-12-01 00:22:47]

LGTM

[commit-bot: I haz the power, 2016-12-01 00:34:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 00:34:55]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-12-01 00:45:51]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-12-01 00:45:51]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2511233002/#ps180001
(title: ".")

[commit-bot: I haz the power, 2016-12-01 00:46:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 01:44:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 01:44:54]

Failed to apply patch for ui/aura/mus/window_port_mus.h:
While running git apply --index -p1;
  error: patch failed: ui/aura/mus/window_port_mus.h:238
  error: ui/aura/mus/window_port_mus.h: patch does not apply

Patch:       ui/aura/mus/window_port_mus.h
Index: ui/aura/mus/window_port_mus.h
diff --git a/ui/aura/mus/window_port_mus.h b/ui/aura/mus/window_port_mus.h
index
32770cab064c2b94fdf158fb0761072f65f89304..8ff4877f85e3060ac362e6cb10e0b7df7af42b94
100644
--- a/ui/aura/mus/window_port_mus.h
+++ b/ui/aura/mus/window_port_mus.h
@@ -238,7 +238,7 @@ class AURA_EXPORT WindowPortMus : public WindowPort, public
WindowMus {
   ServerChangeIdType next_server_change_id_ = 0;
   ServerChanges server_changes_;
 
-  SurfaceIdHandler* surface_id_handler_;
+  SurfaceIdHandler* surface_id_handler_ = nullptr;
   std::unique_ptr<SurfaceInfo> surface_info_;
 
   ui::mojom::Cursor predefined_cursor_ = ui::mojom::Cursor::CURSOR_NULL;

[Ben Goodger (Google), 2016-12-01 16:58:09]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-12-01 16:58:10]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2511233002/#ps200001
(title: ".")

[commit-bot: I haz the power, 2016-12-01 16:58:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 17:59:52]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1480611489954120,
"parent_rev": "1e48d83cad2e18594f30f3d2f92c445bd8a10a76", "commit_rev":
"5a449529479e0dbee5bb5f75c4bf6bf255b7f6e0"}

[commit-bot: I haz the power, 2016-12-01 18:00:17]

Description was changed from

==========
Add the beginning of a simple window manager that we'll support on Windows.

You can now run an alternative window manager from mash_session, mash_init etc
by passing --window-manager=<name_of_wm>

R=sky@chromium.org
==========

to

==========
Add the beginning of a simple window manager that we'll support on Windows.

You can now run an alternative window manager from mash_session, mash_init etc
by passing --window-manager=<name_of_wm>

R=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-12-01 18:00:21]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-12-01 18:04:19]

Description was changed from

==========
Add the beginning of a simple window manager that we'll support on Windows.

You can now run an alternative window manager from mash_session, mash_init etc
by passing --window-manager=<name_of_wm>

R=sky@chromium.org
==========

to

==========
Add the beginning of a simple window manager that we'll support on Windows.

You can now run an alternative window manager from mash_session, mash_init etc
by passing --window-manager=<name_of_wm>

R=sky@chromium.org

Committed: https://crrev.com/f620093a36270014a1964979906a47e672f16c4d
Cr-Commit-Position: refs/heads/master@{#435648}
==========

[commit-bot: I haz the power, 2016-12-01 18:04:20]

Patchset 11 (id:??) landed as
https://crrev.com/f620093a36270014a1964979906a47e672f16c4d
Cr-Commit-Position: refs/heads/master@{#435648}