Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2620343003: Remove unused parameter from FontFace::loadWithCallback() (Closed)

Created:
3 years, 11 months ago by Kunihiko Sakamoto
Modified:
3 years, 11 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused parameter from FontFace::loadWithCallback() The ExecutionContext parameter of loadWithCallback() was a leftover from the FontLoader cleanup (http://crrev.com/1829403002). No behavior changes. Review-Url: https://codereview.chromium.org/2620343003 Cr-Commit-Position: refs/heads/master@{#443182} Committed: https://chromium.googlesource.com/chromium/src/+/72dcc15f98e62d5774e286196479cca6a88a404d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -17 lines) Patch
M third_party/WebKit/Source/core/css/FontFace.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFace.cpp View 2 chunks +5 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceSet.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (15 generated)
Kunihiko Sakamoto
3 years, 11 months ago (2017-01-12 07:10:50 UTC) #12
kouhei (in TOK)
lgtm > BUG= Remove this line from desc.
3 years, 11 months ago (2017-01-12 07:56:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620343003/1
3 years, 11 months ago (2017-01-12 08:01:08 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 08:05:19 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/72dcc15f98e62d5774e286196479...

Powered by Google App Engine
This is Rietveld 408576698