Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: third_party/WebKit/Source/core/css/FontFaceSet.cpp

Issue 2620343003: Remove unused parameter from FontFace::loadWithCallback() (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/FontFace.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/FontFaceSet.cpp
diff --git a/third_party/WebKit/Source/core/css/FontFaceSet.cpp b/third_party/WebKit/Source/core/css/FontFaceSet.cpp
index 5893a9f4ec674be88ca28d21dd46c470d34a3479..54c99074ec9b719f61e528babbbffd320c8b2795 100644
--- a/third_party/WebKit/Source/core/css/FontFaceSet.cpp
+++ b/third_party/WebKit/Source/core/css/FontFaceSet.cpp
@@ -58,7 +58,7 @@ class LoadFontPromiseResolver final
return new LoadFontPromiseResolver(faces, scriptState);
}
- void loadFonts(ExecutionContext*);
+ void loadFonts();
ScriptPromise promise() { return m_resolver->promise(); }
void notifyLoaded(FontFace*) override;
@@ -80,14 +80,14 @@ class LoadFontPromiseResolver final
Member<ScriptPromiseResolver> m_resolver;
};
-void LoadFontPromiseResolver::loadFonts(ExecutionContext* context) {
+void LoadFontPromiseResolver::loadFonts() {
if (!m_numLoading) {
m_resolver->resolve(m_fontFaces);
return;
}
for (size_t i = 0; i < m_fontFaces.size(); i++)
- m_fontFaces[i]->loadWithCallback(this, context);
+ m_fontFaces[i]->loadWithCallback(this);
}
void LoadFontPromiseResolver::notifyLoaded(FontFace* fontFace) {
@@ -396,7 +396,7 @@ ScriptPromise FontFaceSet::load(ScriptState* scriptState,
LoadFontPromiseResolver::create(faces, scriptState);
ScriptPromise promise = resolver->promise();
// After this, resolver->promise() may return null.
- resolver->loadFonts(getExecutionContext());
+ resolver->loadFonts();
return promise;
}
« no previous file with comments | « third_party/WebKit/Source/core/css/FontFace.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698