third_party/WebKit/Source/core/css/FontFace.h - Issue 2620343003: Remove unused parameter from FontFace::loadWithCallback()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/FontFace.h

Issue 2620343003: Remove unused parameter from FontFace::loadWithCallback() (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/FontFace.h

diff --git a/third_party/WebKit/Source/core/css/FontFace.h b/third_party/WebKit/Source/core/css/FontFace.h

index f4ed0f6019a8b60385c0e96022349c67dbcb0104..5f12f10641f9e57ce5a6bb712f110dc3c5f46c94 100644

--- a/third_party/WebKit/Source/core/css/FontFace.h

+++ b/third_party/WebKit/Source/core/css/FontFace.h

@@ -119,7 +119,7 @@ class FontFace : public GarbageCollectedFinalized<FontFace>,

virtual void notifyError(FontFace*) = 0;

DEFINE_INLINE_VIRTUAL_TRACE() {}

};

- void loadWithCallback(LoadFontCallback*, ExecutionContext*);

+ void loadWithCallback(LoadFontCallback*);

void addCallback(LoadFontCallback*);

// ScriptWrappable:

@@ -153,7 +153,6 @@ class FontFace : public GarbageCollectedFinalized<FontFace>,

bool setPropertyFromStyle(const StylePropertySet&, CSSPropertyID);

bool setPropertyValue(const CSSValue*, CSSPropertyID);

bool setFamilyValue(const CSSValue&);

- void loadInternal(ExecutionContext*);

ScriptPromise fontStatusPromise(ScriptState*);

using LoadedProperty = ScriptPromiseProperty<Member<FontFace>,

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/FontFace.cpp » ('j') | no next file with comments »