[ARM] Add vand, vorr NEON instructions.

[ARM] Add vand, vorr NEON instructions.

LOG=N
BUG=v8:4124
Review-Url: https://codereview.chromium.org/2620343002
Cr-Commit-Position: refs/heads/master@{#42273}
Committed: https://chromium.googlesource.com/v8/v8/+/148a903d92040d004a472ef3423211975ec3cb6d

[bbudge, 2017-01-11 11:46:03]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 11:46:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bbudge, 2017-01-11 11:51:20]

bbudge@chromium.org changed reviewers:
+ martyn.capewell@arm.com

[commit-bot: I haz the power, 2017-01-11 12:19:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 12:19:39]

Dry run: This issue passed the CQ dry run.

[martyn.capewell, 2017-01-11 13:47:44]

https://codereview.chromium.org/2620343002/diff/1/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):

https://codereview.chromium.org/2620343002/diff/1/src/arm/assembler-arm.cc#ne...
src/arm/assembler-arm.cc:4151: void Assembler::vand(QwNeonRegister dst,
QwNeonRegister src1,
It would be good to factor these into a single function that can encode all of
the two register source bitwise operations: and, bic, bif, bit, bsl, eor, orr,
orn. They use bits 20, 21 and 24 to encode the eight operations.

[bbudge, 2017-01-12 10:44:55]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 10:45:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bbudge, 2017-01-12 10:53:18]

https://codereview.chromium.org/2620343002/diff/1/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):

https://codereview.chromium.org/2620343002/diff/1/src/arm/assembler-arm.cc#ne...
src/arm/assembler-arm.cc:4151: void Assembler::vand(QwNeonRegister dst,
QwNeonRegister src1,
On 2017/01/11 13:47:44, martyn.capewell wrote:
> It would be good to factor these into a single function that can encode all of
> the two register source bitwise operations: and, bic, bif, bit, bsl, eor, orr,
> orn. They use bits 20, 21 and 24 to encode the eight operations.

Great, thanks. The existing vbsl implementation was folded into this too. Done.

[bbudge, 2017-01-12 11:07:29]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 11:07:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 11:13:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 11:13:43]

Dry run: This issue passed the CQ dry run.

[martyn.capewell, 2017-01-12 14:28:16]

lgtm

[bbudge, 2017-01-12 14:44:21]

The CQ bit was checked by bbudge@chromium.org

[commit-bot: I haz the power, 2017-01-12 14:44:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 14:46:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 14:47:00]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/32173)

[bbudge, 2017-01-12 15:01:40]

The CQ bit was checked by bbudge@chromium.org

[bbudge, 2017-01-12 15:01:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
martyn.capewell@arm.com
Link to the patchset: https://codereview.chromium.org/2620343002/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-01-12 15:01:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 15:36:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484233300322380,
"parent_rev": "ee2f07b67787fead9aeaef8d2cef8a328940931d", "commit_rev":
"148a903d92040d004a472ef3423211975ec3cb6d"}

[commit-bot: I haz the power, 2017-01-12 15:36:35]

Description was changed from

==========
[ARM] Add vand, vorr NEON instructions.

LOG=N
BUG=v8:4124
==========

to

==========
[ARM] Add vand, vorr NEON instructions.

LOG=N
BUG=v8:4124

Review-Url: https://codereview.chromium.org/2620343002
Cr-Commit-Position: refs/heads/master@{#42273}
Committed:
https://chromium.googlesource.com/v8/v8/+/148a903d92040d004a472ef3423211975ec...
==========

[commit-bot: I haz the power, 2017-01-12 15:36:36]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/148a903d92040d004a472ef3423211975ec...