Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2619963005: Multi-install cleanups in setup. (Closed)

Created:
3 years, 11 months ago by grt (UTC plus 2)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Multi-install cleanups in setup. Including: - Removes the "multi-install" crash key from setup.exe. - Removes some dead test code. - Removes duplicated code in IsActivelyUsedIn. BUG=577816 Review-Url: https://codereview.chromium.org/2619963005 Cr-Commit-Position: refs/heads/master@{#442883} Committed: https://chromium.googlesource.com/chromium/src/+/33819cefcc12915026026b12e66fc773fa531ceb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -64 lines) Patch
M chrome/installer/setup/installer_crash_reporting.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/installer/setup/installer_state_unittest.cc View 3 chunks +1 line, -26 lines 0 comments Download
M chrome/installer/setup/setup_util.cc View 3 chunks +7 lines, -35 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (4 generated)
Sébastien Marchand
lgtm
3 years, 11 months ago (2017-01-10 18:39:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619963005/1
3 years, 11 months ago (2017-01-11 11:52:32 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 12:32:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/33819cefcc12915026026b12e66f...

Powered by Google App Engine
This is Rietveld 408576698