Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2594113002: Remove multi-install from installer_util. (Closed)

Created:
3 years, 12 months ago by grt (UTC plus 2)
Modified:
3 years, 11 months ago
Reviewers:
robertshield
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove multi-install from installer_util. This cleanup CL: - Removes InstallUtil::IsMultiInstall. - Removes MasterPreferences::is_multi_install. - Removes various multi-related constants. BUG=577816 Review-Url: https://codereview.chromium.org/2594113002 Cr-Commit-Position: refs/heads/master@{#442894} Committed: https://chromium.googlesource.com/chromium/src/+/c38084e12ff9707e2cc07ff82e004980c43c99c9

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : stragglers #

Patch Set 4 : sync to position 441108 #

Patch Set 5 : rebase onto issue 2618583005 #

Patch Set 6 : rebase #

Patch Set 7 : go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -47 lines) Patch
M chrome/installer/util/install_util.h View 1 2 3 4 5 6 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/installer/util/install_util.cc View 1 2 3 4 5 6 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/installer/util/installation_state.cc View 1 2 3 4 5 6 2 chunks +2 lines, -1 line 0 comments Download
M chrome/installer/util/master_preferences.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/util/master_preferences.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/installer/util/master_preferences_constants.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/util/master_preferences_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/master_preferences_unittest.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/installer/util/util_constants.h View 1 2 3 4 5 6 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/installer/util/util_constants.cc View 1 2 3 4 5 6 2 chunks +0 lines, -8 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 36 (33 generated)
robertshield
lgtm
3 years, 11 months ago (2017-01-10 14:55:10 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594113002/180001
3 years, 11 months ago (2017-01-11 12:34:28 UTC) #33
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 13:54:44 UTC) #36
Message was sent while issue was closed.
Committed patchset #7 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/c38084e12ff9707e2cc07ff82e00...

Powered by Google App Engine
This is Rietveld 408576698