Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2619763003: PPC: Implement VSX instructions (Closed)

Created:
3 years, 11 months ago by JaideepBajwa
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Implement VSX instructions Add VSX instructions to perform add/sub/mul/div R=jyan@ca.ibm.com, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, danno@chromium.org, jkummerow@chromium.org, jochen@chromium.org BUG= LOG=N Review-Url: https://codereview.chromium.org/2619763003 Cr-Commit-Position: refs/heads/master@{#42272} Committed: https://chromium.googlesource.com/v8/v8/+/ee2f07b67787fead9aeaef8d2cef8a328940931d

Patch Set 1 #

Patch Set 2 : Fix disassembler instr string #

Patch Set 3 : Fixed native assembler code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -4 lines) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +20 lines, -4 lines 0 comments Download
M src/globals.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/assembler-ppc.h View 2 chunks +13 lines, -0 lines 0 comments Download
M src/ppc/assembler-ppc.cc View 1 2 4 chunks +28 lines, -0 lines 0 comments Download
M src/ppc/constants-ppc.h View 1 2 2 chunks +28 lines, -0 lines 0 comments Download
M src/ppc/disasm-ppc.cc View 1 3 chunks +27 lines, -0 lines 0 comments Download
M src/ppc/simulator-ppc.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/simulator-ppc.cc View 2 chunks +49 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
john.yan
I think you also need to update lithium-ppc.cc to use dst != src1 form.
3 years, 11 months ago (2017-01-09 18:57:36 UTC) #3
JaideepBajwa
ptal
3 years, 11 months ago (2017-01-11 18:01:52 UTC) #5
john.yan
lgtm
3 years, 11 months ago (2017-01-11 18:05:00 UTC) #7
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-12 08:32:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619763003/40001
3 years, 11 months ago (2017-01-12 15:07:13 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 15:09:15 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/ee2f07b67787fead9aeaef8d2cef8a32894...

Powered by Google App Engine
This is Rietveld 408576698