Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2619383002: [ios] Removed webDidFinishWithURL:loadSuccess: from CRWWebDelegate. (Closed)

Created:
3 years, 11 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removed webDidFinishWithURL:loadSuccess: from CRWWebDelegate. Notable changes: - Tab now conforms to CRWWebStateObserver - Tab implements didFinishWithURL:loadSuccess: instead of webDidFinishWithURL:loadSuccess: - CRWWebController calls SetIsLoading(false) first and then OnPageLoaded (this way IsLoading returns false inside didFinishWithURL:loadSuccess:) BUG=674991 Review-Url: https://codereview.chromium.org/2619383002 Cr-Commit-Position: refs/heads/master@{#442574} Committed: https://chromium.googlesource.com/chromium/src/+/25371c65e843d76f82b0a828a71859c3862b9b3e

Patch Set 1 #

Patch Set 2 : Fixed tests #

Patch Set 3 : Updated pragma mark #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -22 lines) Patch
M ios/chrome/browser/tabs/tab.mm View 1 2 10 chunks +22 lines, -10 lines 0 comments Download
M ios/chrome/browser/tabs/tab_unittest.mm View 1 2 chunks +2 lines, -3 lines 0 comments Download
M ios/web/public/web_state/ui/crw_web_delegate.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Eugene But (OOO till 7-30)
3 years, 11 months ago (2017-01-09 20:53:27 UTC) #10
marq (ping after 24h)
lgtm
3 years, 11 months ago (2017-01-10 10:27:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619383002/40001
3 years, 11 months ago (2017-01-10 13:53:40 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 14:04:18 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/25371c65e843d76f82b0a828a718...

Powered by Google App Engine
This is Rietveld 408576698