[ios] Removed webDidFinishWithURL:loadSuccess: from CRWWebDelegate.

[ios] Removed webDidFinishWithURL:loadSuccess: from CRWWebDelegate.

Notable changes:
 - Tab now conforms to CRWWebStateObserver
 - Tab implements didFinishWithURL:loadSuccess: instead of
   webDidFinishWithURL:loadSuccess:
 - CRWWebController calls SetIsLoading(false) first and then
   OnPageLoaded (this way IsLoading returns false inside
   didFinishWithURL:loadSuccess:)

BUG=674991
Review-Url: https://codereview.chromium.org/2619383002
Cr-Commit-Position: refs/heads/master@{#442574}
Committed: https://chromium.googlesource.com/chromium/src/+/25371c65e843d76f82b0a828a71859c3862b9b3e

[Eugene But (OOO till 7-30), 2017-01-09 19:22:45]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 19:23:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 19:31:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 19:31:13]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Eugene But (OOO till 7-30), 2017-01-09 19:54:05]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 19:54:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 20:15:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 20:15:15]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-01-09 20:53:26]

eugenebut@chromium.org changed reviewers:
+ marq@chromium.org

[marq (ping after 24h), 2017-01-10 10:27:00]

lgtm

[Eugene But (OOO till 7-30), 2017-01-10 13:53:26]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-01-10 13:53:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 14:03:40]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484056406385270,
"parent_rev": "1a5a88a44dcfc171d6fff65abe844c9eb631c253", "commit_rev":
"25371c65e843d76f82b0a828a71859c3862b9b3e"}

[commit-bot: I haz the power, 2017-01-10 14:04:16]

Description was changed from

==========
[ios] Removed webDidFinishWithURL:loadSuccess: from CRWWebDelegate.

Notable changes:
 - Tab now conforms to CRWWebStateObserver
 - Tab implements didFinishWithURL:loadSuccess: instead of
   webDidFinishWithURL:loadSuccess:
 - CRWWebController calls SetIsLoading(false) first and then
   OnPageLoaded (this way IsLoading returns false inside
   didFinishWithURL:loadSuccess:)

BUG=674991
==========

to

==========
[ios] Removed webDidFinishWithURL:loadSuccess: from CRWWebDelegate.

Notable changes:
 - Tab now conforms to CRWWebStateObserver
 - Tab implements didFinishWithURL:loadSuccess: instead of
   webDidFinishWithURL:loadSuccess:
 - CRWWebController calls SetIsLoading(false) first and then
   OnPageLoaded (this way IsLoading returns false inside
   didFinishWithURL:loadSuccess:)

BUG=674991

Review-Url: https://codereview.chromium.org/2619383002
Cr-Commit-Position: refs/heads/master@{#442574}
Committed:
https://chromium.googlesource.com/chromium/src/+/25371c65e843d76f82b0a828a718...
==========

[commit-bot: I haz the power, 2017-01-10 14:04:18]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/25371c65e843d76f82b0a828a718...