Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: ios/chrome/browser/tabs/tab_unittest.mm

Issue 2619383002: [ios] Removed webDidFinishWithURL:loadSuccess: from CRWWebDelegate. (Closed)
Patch Set: Updated pragma mark Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab.mm ('k') | ios/web/public/web_state/ui/crw_web_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab_unittest.mm
diff --git a/ios/chrome/browser/tabs/tab_unittest.mm b/ios/chrome/browser/tabs/tab_unittest.mm
index b87048136087251b35a3c03a556e5124d2ef7ef2..2b495893831b8fa2e8adaab8391798c78c91c81c 100644
--- a/ios/chrome/browser/tabs/tab_unittest.mm
+++ b/ios/chrome/browser/tabs/tab_unittest.mm
@@ -243,8 +243,7 @@ class TabTest : public BlockCleanupTest {
[tab_ webController:mock_web_controller_ titleDidChange:title];
[[[(id)mock_web_controller_ expect]
andReturnValue:OCMOCK_VALUE(kPageLoaded)] loadPhase];
- [[tab_ webController] webStateImpl]->OnPageLoaded(redirectUrl, true);
- [tab_ webDidFinishWithURL:redirectUrl loadSuccess:YES];
+ [tab_ webStateImpl]->OnPageLoaded(redirectUrl, true);
}
void BrowseToNewTab() {
@@ -259,7 +258,7 @@ class TabTest : public BlockCleanupTest {
[tab_ webDidStartLoadingURL:url shouldUpdateHistory:YES];
[[[(id)mock_web_controller_ expect]
andReturnValue:OCMOCK_VALUE(kPageLoaded)] loadPhase];
- [tab_ webDidFinishWithURL:url loadSuccess:YES];
+ [tab_ webStateImpl]->OnPageLoaded(url, true);
[tab_ webController:mock_web_controller_ titleDidChange:kNewTabTitle];
}
« no previous file with comments | « ios/chrome/browser/tabs/tab.mm ('k') | ios/web/public/web_state/ui/crw_web_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698