Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1513)

Side by Side Diff: ios/web/public/web_state/ui/crw_web_delegate.h

Issue 2619383002: [ios] Removed webDidFinishWithURL:loadSuccess: from CRWWebDelegate. (Closed)
Patch Set: Updated pragma mark Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab_unittest.mm ('k') | ios/web/web_state/ui/crw_web_controller.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_WEB_PUBLIC_WEB_STATE_UI_CRW_WEB_DELEGATE_H_ 5 #ifndef IOS_WEB_PUBLIC_WEB_STATE_UI_CRW_WEB_DELEGATE_H_
6 #define IOS_WEB_PUBLIC_WEB_STATE_UI_CRW_WEB_DELEGATE_H_ 6 #define IOS_WEB_PUBLIC_WEB_STATE_UI_CRW_WEB_DELEGATE_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 #import <UIKit/UIKit.h> 9 #import <UIKit/UIKit.h>
10 #include <vector> 10 #include <vector>
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 // Called when webWillStartLoadingURL was called, but something went wrong, and 71 // Called when webWillStartLoadingURL was called, but something went wrong, and
72 // webDidStartLoadingURL will now never be called. 72 // webDidStartLoadingURL will now never be called.
73 - (void)webCancelStartLoadingRequest; 73 - (void)webCancelStartLoadingRequest;
74 // Called when the page URL has changed. Phase will be PAGE_LOADING. Can be 74 // Called when the page URL has changed. Phase will be PAGE_LOADING. Can be
75 // followed by webDidFinishWithURL or webWillStartLoadingURL. 75 // followed by webDidFinishWithURL or webWillStartLoadingURL.
76 // |updateHistory| is YES if the URL should be added to the history DB. 76 // |updateHistory| is YES if the URL should be added to the history DB.
77 // TODO(stuartmorgan): Remove or rename the history param; the history DB 77 // TODO(stuartmorgan): Remove or rename the history param; the history DB
78 // isn't a web concept, so this shoud be expressed differently. 78 // isn't a web concept, so this shoud be expressed differently.
79 - (void)webDidStartLoadingURL:(const GURL&)url 79 - (void)webDidStartLoadingURL:(const GURL&)url
80 shouldUpdateHistory:(BOOL)updateHistory; 80 shouldUpdateHistory:(BOOL)updateHistory;
81 // Called when the page finishes loading, with the URL, page title and load
82 // success status. Phase will be PAGE_LOADED.
83 // On the next navigation event, this will be followed by a call to
84 // webWillStartLoadingURL.
85 - (void)webDidFinishWithURL:(const GURL&)url
86 loadSuccess:(BOOL)loadSuccess;
87 // Called when the page load was cancelled by page activity (before a success / 81 // Called when the page load was cancelled by page activity (before a success /
88 // failure state is known). Phase will be PAGE_LOADED. 82 // failure state is known). Phase will be PAGE_LOADED.
89 - (void)webLoadCancelled:(const GURL&)url; 83 - (void)webLoadCancelled:(const GURL&)url;
90 // Called when a page updates its history stack using pushState or replaceState. 84 // Called when a page updates its history stack using pushState or replaceState.
91 // TODO(stuartmorgan): Generalize this to cover any change of URL without page 85 // TODO(stuartmorgan): Generalize this to cover any change of URL without page
92 // document change. 86 // document change.
93 - (void)webDidUpdateHistoryStateWithPageURL:(const GURL&)pageUrl; 87 - (void)webDidUpdateHistoryStateWithPageURL:(const GURL&)pageUrl;
94 // Called when a placeholder image should be displayed instead of the WebView. 88 // Called when a placeholder image should be displayed instead of the WebView.
95 - (void)webController:(CRWWebController*)webController 89 - (void)webController:(CRWWebController*)webController
96 retrievePlaceholderOverlayImage:(void (^)(UIImage*))block; 90 retrievePlaceholderOverlayImage:(void (^)(UIImage*))block;
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 // Called when a PassKit file is downloaded. |data| should be the data from a 193 // Called when a PassKit file is downloaded. |data| should be the data from a
200 // PassKit file, but this is not guaranteed, and the delegate is responsible for 194 // PassKit file, but this is not guaranteed, and the delegate is responsible for
201 // error handling non PassKit data using -[PKPass initWithData:error:]. If the 195 // error handling non PassKit data using -[PKPass initWithData:error:]. If the
202 // download does not successfully complete, |data| will be nil. 196 // download does not successfully complete, |data| will be nil.
203 - (void)webController:(CRWWebController*)webController 197 - (void)webController:(CRWWebController*)webController
204 didLoadPassKitObject:(NSData*)data; 198 didLoadPassKitObject:(NSData*)data;
205 199
206 @end 200 @end
207 201
208 #endif // IOS_WEB_PUBLIC_WEB_STATE_UI_CRW_WEB_DELEGATE_H_ 202 #endif // IOS_WEB_PUBLIC_WEB_STATE_UI_CRW_WEB_DELEGATE_H_
OLDNEW
« no previous file with comments | « ios/chrome/browser/tabs/tab_unittest.mm ('k') | ios/web/web_state/ui/crw_web_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698