ParamVarDecl should never be renamed to kConstantStyle.

ParamVarDecl should never be renamed to kConstantStyle.

BUG=678137
Committed: https://crrev.com/ec5c0edf462ee18823f505a754a53622a77a104b
Cr-Commit-Position: refs/heads/master@{#441515}

[Łukasz Anforowicz, 2017-01-04 23:07:32]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2017-01-04 23:07:33]

dcheng@, could you PTAL?

[danakj, 2017-01-04 23:18:29]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2017-01-04 23:18:29]

driveby LGTM

[dcheng, 2017-01-04 23:21:32]

LGTM with nit

https://codereview.chromium.org/2618543002/diff/1/tools/clang/rewrite_to_chro...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/2618543002/diff/1/tools/clang/rewrite_to_chro...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:335: if
(clang::ParmVarDecl::classof(&decl))
Nit: more standard to write:

clang::isa<clang::ParmVarDecl>(&decl)

IIRC, classof is an internal implementation detail that supports the isa/dyncast
machinery.

[Łukasz Anforowicz, 2017-01-04 23:30:43]

https://codereview.chromium.org/2618543002/diff/1/tools/clang/rewrite_to_chro...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/2618543002/diff/1/tools/clang/rewrite_to_chro...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:335: if
(clang::ParmVarDecl::classof(&decl))
On 2017/01/04 23:21:31, dcheng wrote:
> Nit: more standard to write:
> 
> clang::isa<clang::ParmVarDecl>(&decl)
> 
> IIRC, classof is an internal implementation detail that supports the
isa/dyncast
> machinery.

Thanks.  I was trying to recall/find how to spell this and had trouble wit this.
 Done.

[Łukasz Anforowicz, 2017-01-04 23:30:47]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-01-04 23:30:47]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2618543002/#ps20001
(title: "Using:  clang::isa<clang::ParmVarDecl>(&decl)")

[commit-bot: I haz the power, 2017-01-04 23:31:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 23:43:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483572647463820,
"parent_rev": "5e0956347715de30c489f219e8b89033ec98625e", "commit_rev":
"897ba6ebefe4ecea11090f8b9cf530f335c8cd4c"}

[commit-bot: I haz the power, 2017-01-04 23:44:08]

Description was changed from

==========
ParamVarDecl should never be renamed to kConstantStyle.

BUG=678137
==========

to

==========
ParamVarDecl should never be renamed to kConstantStyle.

BUG=678137

Review-Url: https://codereview.chromium.org/2618543002
==========

[commit-bot: I haz the power, 2017-01-04 23:44:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-04 23:47:21]

Description was changed from

==========
ParamVarDecl should never be renamed to kConstantStyle.

BUG=678137

Review-Url: https://codereview.chromium.org/2618543002
==========

to

==========
ParamVarDecl should never be renamed to kConstantStyle.

BUG=678137

Committed: https://crrev.com/ec5c0edf462ee18823f505a754a53622a77a104b
Cr-Commit-Position: refs/heads/master@{#441515}
==========

[commit-bot: I haz the power, 2017-01-04 23:47:22]

Patchset 2 (id:??) landed as
https://crrev.com/ec5c0edf462ee18823f505a754a53622a77a104b
Cr-Commit-Position: refs/heads/master@{#441515}