Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2618543002: ParamVarDecl should never be renamed to kConstantStyle. (Closed)

Created:
3 years, 11 months ago by Łukasz Anforowicz
Modified:
3 years, 11 months ago
Reviewers:
danakj, dcheng
CC:
chromium-reviews, danakj
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ParamVarDecl should never be renamed to kConstantStyle. BUG=678137 Committed: https://crrev.com/ec5c0edf462ee18823f505a754a53622a77a104b Cr-Commit-Position: refs/heads/master@{#441515}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Using: clang::isa<clang::ParmVarDecl>(&decl) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tools/clang/rewrite_to_chrome_style/tests/constants-original.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Łukasz Anforowicz
dcheng@, could you PTAL?
3 years, 11 months ago (2017-01-04 23:07:33 UTC) #2
danakj
driveby LGTM
3 years, 11 months ago (2017-01-04 23:18:29 UTC) #4
dcheng
LGTM with nit https://codereview.chromium.org/2618543002/diff/1/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right): https://codereview.chromium.org/2618543002/diff/1/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp#newcode335 tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:335: if (clang::ParmVarDecl::classof(&decl)) Nit: more standard to ...
3 years, 11 months ago (2017-01-04 23:21:32 UTC) #5
Łukasz Anforowicz
https://codereview.chromium.org/2618543002/diff/1/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right): https://codereview.chromium.org/2618543002/diff/1/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp#newcode335 tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:335: if (clang::ParmVarDecl::classof(&decl)) On 2017/01/04 23:21:31, dcheng wrote: > Nit: ...
3 years, 11 months ago (2017-01-04 23:30:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618543002/20001
3 years, 11 months ago (2017-01-04 23:31:24 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 23:44:09 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 23:47:22 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ec5c0edf462ee18823f505a754a53622a77a104b
Cr-Commit-Position: refs/heads/master@{#441515}

Powered by Google App Engine
This is Rietveld 408576698