Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/constants-original.cc

Issue 2618543002: ParamVarDecl should never be renamed to kConstantStyle. (Closed)
Patch Set: Using: clang::isa<clang::ParmVarDecl>(&decl) Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/rewrite_to_chrome_style/tests/constants-original.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/constants-original.cc b/tools/clang/rewrite_to_chrome_style/tests/constants-original.cc
index bc51bffa4edc1cdfea52773bc913930ebc3236db..51ce017823e0e59f29486e025347aa25c2154f8f 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/constants-original.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/constants-original.cc
@@ -42,7 +42,8 @@ class C {
}
};
-void F() {
+// |constParam| should not be renamed to |kConstParam|.
+void F(const bool constParam = true) {
// Constant in function body.
static const char staticString[] = "abc";
// Constant-style naming, since it's initialized with a literal.
« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698