tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc - Issue 2618543002: ParamVarDecl should never be renamed to kConstantStyle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc

Issue 2618543002: ParamVarDecl should never be renamed to kConstantStyle. (Closed)

Patch Set: Using: clang::isa<clang::ParmVarDecl>(&decl) Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc

diff --git a/tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc b/tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc

index e27982ac50f98bc3f369f7aefb083675edcff91e..3f55421bb4356a33149b2f4e24db8e3399384f21 100644

--- a/tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc

+++ b/tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc

@@ -42,7 +42,8 @@ class C {

}

};

-void F() {

+// |constParam| should not be renamed to |kConstParam|.

+void F(const bool const_param = true) {

// Constant in function body.

static const char kStaticString[] = "abc";

// Constant-style naming, since it's initialized with a literal.