Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 2618443003: Revert of [turbofan] Improve codegen for 8- and 16-bit memory comparisons on Intel platforms (Closed)

Created:
3 years, 11 months ago by epertoso
Modified:
3 years, 11 months ago
Reviewers:
danno
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Improve codegen for 8- and 16-bit memory comparisons on Intel platforms (patchset #3 id:40001 of https://codereview.chromium.org/2605863002/ ) Reason for revert: Breaks wasm benchmark (http://crbug.com/v8/5798). Original issue's description: > [turbofan] Improve codegen for 8- and 16-bit memory comparisons on Intel platforms > > Recognize and emit in-memory comparisons of 8-bit and 16-bit values with > immediate values that fit. > > LOG=N > R=epertoso@chromium.org > > Review-Url: https://codereview.chromium.org/2605863002 > Cr-Commit-Position: refs/heads/master@{#41971} > Committed: https://chromium.googlesource.com/v8/v8/+/be11812c53ff6c8ce320887bc76a3b60d8103695 TBR=danno@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2618443003 Cr-Commit-Position: refs/heads/master@{#42092} Committed: https://chromium.googlesource.com/v8/v8/+/c16ca32e5fcacd8e3e08e25a1dd7053015fb43ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -86 lines) Patch
M src/compiler/ia32/instruction-selector-ia32.cc View 2 chunks +13 lines, -44 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +9 lines, -42 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
epertoso
Created Revert of [turbofan] Improve codegen for 8- and 16-bit memory comparisons on Intel platforms
3 years, 11 months ago (2017-01-05 14:34:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618443003/1
3 years, 11 months ago (2017-01-05 14:34:08 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 14:58:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c16ca32e5fcacd8e3e08e25a1dd7053015f...

Powered by Google App Engine
This is Rietveld 408576698