Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2605863002:
[turbofan] Improve codegen for 8- and 16-bit memory comparisons on Intel platforms (Closed)
Description[turbofan] Improve codegen for 8- and 16-bit memory comparisons on Intel platforms (reland)
Recognize and emit in-memory comparisons of 8-bit and 16-bit values with
immediate values that fit.
LOG=N
R=epertoso@chromium.org
Review-Url: https://codereview.chromium.org/2605863002
Cr-Commit-Position: refs/heads/master@{#42344}
Committed: https://chromium.googlesource.com/v8/v8/+/95a9b7611596865d2bea23fde24d0687d8ad0721
Patch Set 1 #Patch Set 2 : Fix stuff #Patch Set 3 : Fix ia32 #Patch Set 4 : Add tests and fix discovered bugs #Patch Set 5 : Fix range error #Patch Set 6 : Fix x64 code generation problems. #Patch Set 7 : Fix build #Patch Set 8 : Swap byte order #Patch Set 9 : Reove 64-bit implementation #Patch Set 10 : Tweaks #Patch Set 11 : Add test case #Patch Set 12 : Fix assert #
Messages
Total messages: 61 (51 generated)
The CQ bit was checked by danno@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ptal
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/18383) v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/18447) v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...) v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/14798)
The CQ bit was checked by danno@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...) v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...) v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/20090)
The CQ bit was checked by danno@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
please take another look
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Great, lgtm!
The CQ bit was checked by danno@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482925814125860,
"parent_rev": "b063b34373bd4e7820d3f08e4281109588d66faf", "commit_rev":
"be11812c53ff6c8ce320887bc76a3b60d8103695"}
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Improve codegen for 8- and 16-bit memory comparisons on Intel platforms Recognize and emit in-memory comparisons of 8-bit and 16-bit values with immediate values that fit. LOG=N R=epertoso@chromium.org ========== to ========== [turbofan] Improve codegen for 8- and 16-bit memory comparisons on Intel platforms Recognize and emit in-memory comparisons of 8-bit and 16-bit values with immediate values that fit. LOG=N R=epertoso@chromium.org Review-Url: https://codereview.chromium.org/2605863002 Cr-Commit-Position: refs/heads/master@{#41971} Committed: https://chromium.googlesource.com/v8/v8/+/be11812c53ff6c8ce320887bc76a3b60d81... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/v8/v8/+/be11812c53ff6c8ce320887bc76a3b60d81...
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2618443003/ by epertoso@chromium.org. The reason for reverting is: Breaks wasm benchmark (http://crbug.com/v8/5798)..
Message was sent while issue was closed.
On 2017/01/05 14:34:00, epertoso wrote: > A revert of this CL (patchset #3 id:40001) has been created in > https://codereview.chromium.org/2618443003/ by mailto:epertoso@chromium.org. > > The reason for reverting is: Breaks wasm benchmark (http://crbug.com/v8/5798).. Looks like our testing in this area is not broad enough. Please add tests when relanding.
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Improve codegen for 8- and 16-bit memory comparisons on Intel platforms Recognize and emit in-memory comparisons of 8-bit and 16-bit values with immediate values that fit. LOG=N R=epertoso@chromium.org Review-Url: https://codereview.chromium.org/2605863002 Cr-Commit-Position: refs/heads/master@{#41971} Committed: https://chromium.googlesource.com/v8/v8/+/be11812c53ff6c8ce320887bc76a3b60d81... ========== to ========== [turbofan] Improve codegen for 8- and 16-bit memory comparisons on Intel platforms Recognize and emit in-memory comparisons of 8-bit and 16-bit values with immediate values that fit. LOG=N R=epertoso@chromium.org ==========
The CQ bit was checked by danno@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [turbofan] Improve codegen for 8- and 16-bit memory comparisons on Intel platforms Recognize and emit in-memory comparisons of 8-bit and 16-bit values with immediate values that fit. LOG=N R=epertoso@chromium.org ========== to ========== [turbofan] Improve codegen for 8- and 16-bit memory comparisons on Intel platforms (reland) Recognize and emit in-memory comparisons of 8-bit and 16-bit values with immediate values that fit. LOG=N R=epertoso@chromium.org ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
The CQ bit was checked by danno@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/18937) v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...) v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/20580) v8_win_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)
The CQ bit was checked by danno@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by danno@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by danno@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by danno@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by danno@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Test cases added and additional problems found and fixed on x64. Please take another look.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by danno@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/18917)
The CQ bit was checked by danno@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by danno@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from epertoso@chromium.org Link to the patchset: https://codereview.chromium.org/2605863002/#ps220001 (title: "Fix assert")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 220001, "attempt_start_ts": 1484348854480310,
"parent_rev": "ac9e628539eec41ebdd7142eebb324683dfe46b7", "commit_rev":
"95a9b7611596865d2bea23fde24d0687d8ad0721"}
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Improve codegen for 8- and 16-bit memory comparisons on Intel platforms (reland) Recognize and emit in-memory comparisons of 8-bit and 16-bit values with immediate values that fit. LOG=N R=epertoso@chromium.org ========== to ========== [turbofan] Improve codegen for 8- and 16-bit memory comparisons on Intel platforms (reland) Recognize and emit in-memory comparisons of 8-bit and 16-bit values with immediate values that fit. LOG=N R=epertoso@chromium.org Review-Url: https://codereview.chromium.org/2605863002 Cr-Commit-Position: refs/heads/master@{#42344} Committed: https://chromium.googlesource.com/v8/v8/+/95a9b7611596865d2bea23fde24d0687d8a... ==========
Message was sent while issue was closed.
Committed patchset #12 (id:220001) as https://chromium.googlesource.com/v8/v8/+/95a9b7611596865d2bea23fde24d0687d8a... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
