Remove ScopedVector from ContentBrowserClient.

Remove ScopedVector from ContentBrowserClient.

BUG=554289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2618393003
Cr-Commit-Position: refs/heads/master@{#443403}
Committed: https://chromium.googlesource.com/chromium/src/+/d6d88b91c89eb59510f0628b0945e5cd65df3871

[Avi (use Gerrit), 2017-01-10 00:54:47]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[Avi (use Gerrit), 2017-01-10 00:54:48]

Description was changed from

==========
Remove ScopedVector from ContentBrowserClient.

BUG=554289
==========

to

==========
Remove ScopedVector from ContentBrowserClient.

BUG=554289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2017-01-10 00:55:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 02:47:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 02:47:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2017-01-10 16:07:05]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 16:07:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 19:48:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 19:48:46]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2017-01-10 22:00:23]

avi@chromium.org changed reviewers:
+ kinuko@chromium.org, michaelbai@chromium.org, rdevlin.cronin@chromium.org,
reillyg@chromium.org, thakis@chromium.org, tzik@chromium.org

[Avi (use Gerrit), 2017-01-10 22:00:23]

michaelbai for aw/
rdevlin.cronin for chrome/browser/extensions, extensions/
reillyg for chrome/browser/media_galleries
tzik for chrome/browser/sync_file_system, content/browser/fileapi
kinuko for storage/
thakis for basically everything else

[Reilly Grant (use Gerrit), 2017-01-10 22:11:30]

chrome/browser/media_galleries lgtm

[Devlin, 2017-01-10 22:39:26]

extensions lgtm

https://codereview.chromium.org/2618393003/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
(right):

https://codereview.chromium.org/2618393003/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc:779:
->GetSequencedTaskRunner(pool->GetNamedSequenceToken(
that's weird.  Did git cl format do this?  Seems like this should be on the
previous line.

[michaelbai, 2017-01-11 01:14:31]

android_webview LGTM

[kinuko, 2017-01-11 05:49:44]

storage lgtm

[tzik, 2017-01-11 07:58:10]

sync_file_system & fileapi LGTM

[Avi (use Gerrit), 2017-01-11 17:20:23]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 17:20:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-01-11 18:14:01]

https://codereview.chromium.org/2618393003/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
(right):

https://codereview.chromium.org/2618393003/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc:779:
->GetSequencedTaskRunner(pool->GetNamedSequenceToken(
On 2017/01/10 22:39:26, Devlin wrote:
> that's weird.  Did git cl format do this?  Seems like this should be on the
> previous line.

Yep, this is clang format.

We have a chain of calls on pool: first ->GetSequencedTaskRunner() and then
.get() on that. This formatting is how clang format formats a chain of calls on
a single object.

I'm going to pull one of these out to help clarify what's going on.

[commit-bot: I haz the power, 2017-01-11 19:14:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 19:14:26]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2017-01-12 16:33:25]

Nico: ping

[Nico, 2017-01-12 16:55:23]

lgtm

https://codereview.chromium.org/2618393003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
(right):

https://codereview.chromium.org/2618393003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc:776:
auto sequence_token =
no auto

https://codereview.chromium.org/2618393003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_navigation_throttle_unittest.cc
(right):

https://codereview.chromium.org/2618393003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_navigation_throttle_unittest.cc:77: false, 
// not post
nit: use CallW..(/*is_post=*/false, content::Referrer(), ...) (and likewise for
hase_user_gesture and is_external_protocol if you feel like it).

clang-format knows not to put a space after the /*foo=*/ comment if it ends in
=, and that way it's 100% clear what this means. As is, it could mean "not post
is set to false (so post is yes)"

https://codereview.chromium.org/2618393003/diff/40001/content/browser/frame_h...
File content/browser/frame_host/navigation_handle_impl.cc (right):

https://codereview.chromium.org/2618393003/diff/40001/content/browser/frame_h...
content/browser/frame_host/navigation_handle_impl.cc:807:
std::make_move_iterator(throttles_to_register.end()));
nice

[Nico, 2017-01-12 16:55:49]

https://codereview.chromium.org/2618393003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
(right):

https://codereview.chromium.org/2618393003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc:776:
auto sequence_token =
On 2017/01/12 16:55:23, Nico wrote:
> no auto

Sorry, meant to delete this comment before posting. Please ignore this one.

[Avi (use Gerrit), 2017-01-12 19:05:37]

https://codereview.chromium.org/2618393003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
(right):

https://codereview.chromium.org/2618393003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc:776:
auto sequence_token =
On 2017/01/12 16:55:49, Nico wrote:
> On 2017/01/12 16:55:23, Nico wrote:
> > no auto
> 
> Sorry, meant to delete this comment before posting. Please ignore this one.

Acknowledged.

https://codereview.chromium.org/2618393003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_navigation_throttle_unittest.cc
(right):

https://codereview.chromium.org/2618393003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_navigation_throttle_unittest.cc:77: false, 
// not post
On 2017/01/12 16:55:23, Nico wrote:
> nit: use CallW..(/*is_post=*/false, content::Referrer(), ...) (and likewise
for
> hase_user_gesture and is_external_protocol if you feel like it).
> 
> clang-format knows not to put a space after the /*foo=*/ comment if it ends in
> =, and that way it's 100% clear what this means. As is, it could mean "not
post
> is set to false (so post is yes)"

Done, and thank you for this; I didn't know this and it's useful.

https://codereview.chromium.org/2618393003/diff/40001/content/browser/frame_h...
File content/browser/frame_host/navigation_handle_impl.cc (right):

https://codereview.chromium.org/2618393003/diff/40001/content/browser/frame_h...
content/browser/frame_host/navigation_handle_impl.cc:807:
std::make_move_iterator(throttles_to_register.end()));
On 2017/01/12 16:55:23, Nico wrote:
> nice

Thank you! Props to leon.han@intel who taught it to me.

[Avi (use Gerrit), 2017-01-12 19:06:29]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2017-01-12 19:06:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org, reillyg@chromium.org, tzik@chromium.org,
michaelbai@chromium.org, kinuko@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2618393003/#ps60001
(title: "nico")

[commit-bot: I haz the power, 2017-01-12 19:07:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 20:47:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 20:47:44]

Failed to apply patch for chrome/browser/chrome_content_browser_client.h:
While running git apply --index -p1;
  error: patch failed: chrome/browser/chrome_content_browser_client.h:295
  error: chrome/browser/chrome_content_browser_client.h: patch does not apply

Patch:       chrome/browser/chrome_content_browser_client.h
Index: chrome/browser/chrome_content_browser_client.h
diff --git a/chrome/browser/chrome_content_browser_client.h
b/chrome/browser/chrome_content_browser_client.h
index
6d6f8bb57ab5d0cf5c7e17a88014ab2f4bfc002b..c314117a474b3e9950bb8b37422dee802f01e7ce
100644
--- a/chrome/browser/chrome_content_browser_client.h
+++ b/chrome/browser/chrome_content_browser_client.h
@@ -245,7 +245,8 @@ class ChromeContentBrowserClient : public
content::ContentBrowserClient {
   void GetAdditionalFileSystemBackends(
       content::BrowserContext* browser_context,
       const base::FilePath& storage_partition_path,
-      ScopedVector<storage::FileSystemBackend>* additional_backends) override;
+      std::vector<std::unique_ptr<storage::FileSystemBackend>>*
+          additional_backends) override;
   content::DevToolsManagerDelegate* GetDevToolsManagerDelegate() override;
   content::TracingDelegate* GetTracingDelegate() override;
   bool IsPluginAllowedToCallRequestOSFileHandle(
@@ -295,8 +296,8 @@ class ChromeContentBrowserClient : public
content::ContentBrowserClient {
   content::PresentationServiceDelegate* GetPresentationServiceDelegate(
       content::WebContents* web_contents) override;
   void RecordURLMetric(const std::string& metric, const GURL& url) override;
-  ScopedVector<content::NavigationThrottle> CreateThrottlesForNavigation(
-      content::NavigationHandle* handle) override;
+  std::vector<std::unique_ptr<content::NavigationThrottle>>
+  CreateThrottlesForNavigation(content::NavigationHandle* handle) override;
   std::unique_ptr<content::NavigationUIData> GetNavigationUIData(
       content::NavigationHandle* navigation_handle) override;
   std::unique_ptr<content::MemoryCoordinatorDelegate>

[Avi (use Gerrit), 2017-01-12 21:13:02]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2017-01-12 21:13:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org, reillyg@chromium.org, tzik@chromium.org,
michaelbai@chromium.org, kinuko@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2618393003/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-12 21:13:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 00:16:04]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484255582496950,
"parent_rev": "4c98cd46c28088618ae90963e1d3708b6508f093", "commit_rev":
"d6d88b91c89eb59510f0628b0945e5cd65df3871"}

[commit-bot: I haz the power, 2017-01-13 00:16:39]

Description was changed from

==========
Remove ScopedVector from ContentBrowserClient.

BUG=554289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove ScopedVector from ContentBrowserClient.

BUG=554289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2618393003
Cr-Commit-Position: refs/heads/master@{#443403}
Committed:
https://chromium.googlesource.com/chromium/src/+/d6d88b91c89eb59510f0628b0945...
==========

[commit-bot: I haz the power, 2017-01-13 00:16:41]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/d6d88b91c89eb59510f0628b0945...