Remove ScopedVector from ContentBrowserClient.

content/browser/frame_host/navigation_handle_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigation_handle_impl.h"
 
+#include <iterator>
+
 #include "base/debug/dump_without_crashing.h"
 #include "base/logging.h"
 #include "content/browser/appcache/appcache_navigation_handle.h"
 #include "content/browser/appcache/appcache_service_impl.h"
 #include "content/browser/browsing_data/clear_site_data_throttle.h"
 #include "content/browser/child_process_security_policy_impl.h"
 #include "content/browser/devtools/render_frame_devtools_agent_host.h"
 #include "content/browser/frame_host/ancestor_throttle.h"
 #include "content/browser/frame_host/debug_urls.h"
 #include "content/browser/frame_host/frame_tree_node.h"
@@ skipping 755 matching lines @@
   complete_callback_.Reset();
 
   if (!callback.is_null())
     callback.Run(result);
 
   // No code after running the callback, as it might have resulted in our
   // destruction.
 }
 
 void NavigationHandleImpl::RegisterNavigationThrottles() {
-  // Register the navigation throttles. The ScopedVector returned by
+  // Register the navigation throttles. The vector returned by
   // GetNavigationThrottles is not assigned to throttles_ directly because it
-  // would overwrite any throttle previously added with
+  // would overwrite any throttles previously added with
   // RegisterThrottleForTesting.
-  ScopedVector<NavigationThrottle> throttles_to_register =
+  std::vector<std::unique_ptr<NavigationThrottle>> throttles_to_register =
       GetDelegate()->CreateThrottlesForNavigation(this);
   std::unique_ptr<NavigationThrottle> devtools_throttle =
       RenderFrameDevToolsAgentHost::CreateThrottleForNavigation(this);
   if (devtools_throttle)
     throttles_to_register.push_back(std::move(devtools_throttle));
 
   std::unique_ptr<NavigationThrottle> clear_site_data_throttle =
       ClearSiteDataThrottle::CreateThrottleForNavigation(this);
   if (clear_site_data_throttle)
     throttles_to_register.push_back(std::move(clear_site_data_throttle));
 
   std::unique_ptr<content::NavigationThrottle> ancestor_throttle =
       content::AncestorThrottle::MaybeCreateThrottleFor(this);
   if (ancestor_throttle)
     throttles_.push_back(std::move(ancestor_throttle));
 
-  if (throttles_to_register.size() > 0) {
-    throttles_.insert(throttles_.begin(), throttles_to_register.begin(),
-                      throttles_to_register.end());
-    throttles_to_register.weak_clear();
-  }
+  throttles_.insert(throttles_.begin(),
+                    std::make_move_iterator(throttles_to_register.begin()),
+                    std::make_move_iterator(throttles_to_register.end()));

[Nico, 2017/01/12 16:55:23]

nice

[Avi (use Gerrit), 2017/01/12 19:05:37]

Thank you! Props to leon.han@intel who taught it to me.

 }
 
 }  // namespace content