Remove ScopedVector from ContentBrowserClient.

chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/chrome_content_browser_client_extensions_part.h"
 
 #include <stddef.h>
 
 #include <set>
 
 #include "base/command_line.h"
 #include "base/debug/alias.h"
 #include "base/debug/dump_without_crashing.h"
+#include "base/memory/ptr_util.h"
 #include "base/metrics/histogram_macros.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_web_ui.h"
 #include "chrome/browser/extensions/extension_webkit_preferences.h"
 #include "chrome/browser/media_galleries/fileapi/media_file_system_backend.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_io_data.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/renderer_host/chrome_extension_message_filter.h"
@@ skipping 738 matching lines @@
 
 void ChromeContentBrowserClientExtensionsPart::GetURLRequestAutoMountHandlers(
     std::vector<storage::URLRequestAutoMountHandler>* handlers) {
   handlers->push_back(
       base::Bind(MediaFileSystemBackend::AttemptAutoMountForURLRequest));
 }
 
 void ChromeContentBrowserClientExtensionsPart::GetAdditionalFileSystemBackends(
     content::BrowserContext* browser_context,
     const base::FilePath& storage_partition_path,
-    ScopedVector<storage::FileSystemBackend>* additional_backends) {
+    std::vector<std::unique_ptr<storage::FileSystemBackend>>*
+        additional_backends) {
   base::SequencedWorkerPool* pool = content::BrowserThread::GetBlockingPool();
-  additional_backends->push_back(new MediaFileSystemBackend(
+  additional_backends->push_back(base::MakeUnique<MediaFileSystemBackend>(
       storage_partition_path,
-      pool->GetSequencedTaskRunner(
-                pool->GetNamedSequenceToken(
-                    MediaFileSystemBackend::kMediaTaskRunnerName)).get()));
+      pool
+          ->GetSequencedTaskRunner(pool->GetNamedSequenceToken(

[Devlin, 2017/01/10 22:39:26]

that's weird.  Did git cl format do this?  Seems like this should be on the
previous line.

[Avi (use Gerrit), 2017/01/11 18:14:01]

Yep, this is clang format.

We have a chain of calls on pool: first ->GetSequencedTaskRunner() and then
.get() on that. This formatting is how clang format formats a chain of calls on
a single object.

I'm going to pull one of these out to help clarify what's going on.

+              MediaFileSystemBackend::kMediaTaskRunnerName))
+          .get()));
 
-  additional_backends->push_back(new sync_file_system::SyncFileSystemBackend(
-      Profile::FromBrowserContext(browser_context)));
+  additional_backends->push_back(
+      base::MakeUnique<sync_file_system::SyncFileSystemBackend>(
+          Profile::FromBrowserContext(browser_context)));
 }
 
 void ChromeContentBrowserClientExtensionsPart::
     AppendExtraRendererCommandLineSwitches(base::CommandLine* command_line,
                                            content::RenderProcessHost* process,
                                            Profile* profile) {
   if (!process)
     return;
   DCHECK(profile);
   if (ProcessMap::Get(profile)->Contains(process->GetID())) {
     command_line->AppendSwitch(switches::kExtensionProcess);
   }
 }
 
 void ChromeContentBrowserClientExtensionsPart::ResourceDispatcherHostCreated() {
   content::ResourceDispatcherHost::Get()->RegisterInterceptor(
       "Origin", kExtensionScheme, base::Bind(&OnHttpHeaderReceived));
 }
 
 }  // namespace extensions