Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2618383004: Revert of Move more vector icons to respective directories and update code to (Closed)

Created:
3 years, 11 months ago by jonross
Modified:
3 years, 11 months ago
Reviewers:
sky, Evan Stade
CC:
chromium-reviews, sadrul, awdf+watch_chromium.org, Peter Beverloo, tfarina, mlamouri+watch-notifications_chromium.org, oshima+watch_chromium.org, kalyank, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move more vector icons to respective directories and update code to (patchset #1 id:1 of https://codereview.chromium.org/2620613005/ ) Reason for revert: Hey, The change in #15 has broken chromium os builds: obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference to 'ash::kWindowControlMinimizeIcon' obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference to 'ash::kWindowControlCloseIcon' obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference to 'ash::kWindowControlLeftSnappedIcon' obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference to 'ash::kWindowControlRightSnappedIcon' obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference to 'ash::kWindowControlRestoreIcon' obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference to 'ash::kWindowControlMaximizeIcon' The new icon constants are not checked in. I will revert to unblock the build. Original issue's description: > Move more vector icons to respective directories and update code to > use gfx::VectorIcon structs instead of the VectorIconId enum. > > Also add version of ImageButton::SetImage that takes a const ref image. > > BUG=626786 > > Review-Url: https://codereview.chromium.org/2620613005 > Cr-Commit-Position: refs/heads/master@{#442488} > Committed: https://chromium.googlesource.com/chromium/src/+/f5157480667e99269e0062e9df1df3875db85197 TBR=sky@chromium.org,estade@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=626786 Review-Url: https://codereview.chromium.org/2618383004 Cr-Commit-Position: refs/heads/master@{#442595} Committed: https://chromium.googlesource.com/chromium/src/+/ad25bdddb113a0986c246b4a046e6f68a327ac98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+346 lines, -348 lines) Patch
M ash/common/frame/caption_buttons/frame_caption_button.h View 4 chunks +6 lines, -4 lines 0 comments Download
M ash/common/frame/caption_buttons/frame_caption_button.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ash/common/frame/caption_buttons/frame_caption_button_container_view.h View 3 chunks +4 lines, -5 lines 0 comments Download
M ash/common/frame/caption_buttons/frame_caption_button_container_view.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M ash/common/frame/caption_buttons/frame_caption_button_container_view_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/common/frame/default_header_painter.cc View 3 chunks +18 lines, -16 lines 0 comments Download
M ash/common/system/tray/tray_popup_header_button.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/common/wm/overview/window_selector_item.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/common/wm/overview/window_selector_item.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ash/frame/caption_buttons/frame_size_button_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ash/resources/vector_icons/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
D ash/resources/vector_icons/window_control_back.icon View 1 chunk +0 lines, -19 lines 0 comments Download
D ash/resources/vector_icons/window_control_back.1x.icon View 1 chunk +0 lines, -18 lines 0 comments Download
D ash/resources/vector_icons/window_control_close.icon View 1 chunk +0 lines, -20 lines 0 comments Download
D ash/resources/vector_icons/window_control_close.1x.icon View 1 chunk +0 lines, -20 lines 0 comments Download
D ash/resources/vector_icons/window_control_left_snapped.icon View 1 chunk +0 lines, -16 lines 0 comments Download
D ash/resources/vector_icons/window_control_left_snapped.1x.icon View 1 chunk +0 lines, -15 lines 0 comments Download
D ash/resources/vector_icons/window_control_maximize.icon View 1 chunk +0 lines, -18 lines 0 comments Download
D ash/resources/vector_icons/window_control_maximize.1x.icon View 1 chunk +0 lines, -18 lines 0 comments Download
D ash/resources/vector_icons/window_control_minimize.icon View 1 chunk +0 lines, -11 lines 0 comments Download
D ash/resources/vector_icons/window_control_minimize.1x.icon View 1 chunk +0 lines, -11 lines 0 comments Download
D ash/resources/vector_icons/window_control_restore.icon View 1 chunk +0 lines, -26 lines 0 comments Download
D ash/resources/vector_icons/window_control_restore.1x.icon View 1 chunk +0 lines, -26 lines 0 comments Download
D ash/resources/vector_icons/window_control_right_snapped.icon View 1 chunk +0 lines, -16 lines 0 comments Download
D ash/resources/vector_icons/window_control_right_snapped.1x.icon View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/options/wimax_config_view.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_header_painter_ash.cc View 3 chunks +13 lines, -11 lines 0 comments Download
M ui/gfx/vector_icons/BUILD.gn View 1 chunk +14 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_back.icon View 1 chunk +19 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_back.1x.icon View 1 chunk +18 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_close.icon View 1 chunk +20 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_close.1x.icon View 1 chunk +20 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_left_snapped.icon View 1 chunk +16 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_left_snapped.1x.icon View 1 chunk +15 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_maximize.icon View 1 chunk +18 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_maximize.1x.icon View 1 chunk +18 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_minimize.icon View 1 chunk +11 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_minimize.1x.icon View 1 chunk +11 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_restore.icon View 1 chunk +26 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_restore.1x.icon View 1 chunk +26 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_right_snapped.icon View 1 chunk +16 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_right_snapped.1x.icon View 1 chunk +15 lines, -0 lines 0 comments Download
M ui/message_center/views/message_center_button_bar.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/controls/button/image_button.h View 2 chunks +2 lines, -7 lines 0 comments Download
M ui/views/controls/button/image_button.cc View 2 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jonross
Created Revert of Move more vector icons to respective directories and update code to
3 years, 11 months ago (2017-01-10 15:53:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618383004/1
3 years, 11 months ago (2017-01-10 15:53:30 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 15:55:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ad25bdddb113a0986c246b4a046e...

Powered by Google App Engine
This is Rietveld 408576698