Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 2618143002: cros: Remove some OS platform ifdefs from ash (Closed)

Created:
3 years, 11 months ago by James Cook
Modified:
3 years, 11 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, jam, sadrul, dcheng, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Remove some OS platform ifdefs from ash Ash only builds on Chrome OS, so there's no need for OS_CHROMEOS and OS_WIN checks. BUG=666773 TEST=compiles Review-Url: https://codereview.chromium.org/2618143002 Cr-Commit-Position: refs/heads/master@{#442318} Committed: https://chromium.googlesource.com/chromium/src/+/01bf23e7e27102560b44f1353d8f55e6dd62457a

Patch Set 1 #

Patch Set 2 : gncheck #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -659 lines) Patch
M ash/app_list/app_list_presenter_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/aura/wm_shell_aura.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/aura/wm_shell_aura.cc View 4 chunks +1 line, -6 lines 0 comments Download
M ash/content/shell_content_state.h View 2 chunks +1 line, -5 lines 0 comments Download
M ash/content/shell_content_state.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M ash/dip_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 6 chunks +6 lines, -45 lines 0 comments Download
M ash/drag_drop/drag_drop_interactive_uitest.cc View 1 chunk +1 line, -7 lines 0 comments Download
M ash/magnifier/magnification_controller_unittest.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M ash/metrics/user_metrics_recorder.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ash/metrics/user_metrics_recorder.cc View 3 chunks +1 line, -8 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/mus/context_menu_mus.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/mus/shell_delegate_mus.cc View 3 chunks +1 line, -12 lines 0 comments Download
M ash/mus/window_manager_application.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/mus/window_manager_application.cc View 7 chunks +11 lines, -19 lines 0 comments Download
M ash/root_window_controller.h View 3 chunks +2 lines, -7 lines 0 comments Download
M ash/root_window_controller.cc View 13 chunks +4 lines, -23 lines 0 comments Download
M ash/root_window_controller_unittest.cc View 1 chunk +1 line, -8 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 4 chunks +5 lines, -32 lines 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 6 chunks +0 lines, -11 lines 0 comments Download
M ash/shell.h View 1 2 9 chunks +0 lines, -11 lines 0 comments Download
M ash/shell.cc View 1 2 31 chunks +32 lines, -94 lines 0 comments Download
M ash/shell/content/client/shell_browser_main_parts.cc View 5 chunks +3 lines, -12 lines 0 comments Download
M ash/shell/content/shell_with_content_main.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M ash/shell_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/system/overview/overview_button_tray_unittest.cc View 1 chunk +1 line, -7 lines 0 comments Download
M ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc View 3 chunks +3 lines, -21 lines 0 comments Download
M ash/system/web_notification/web_notification_tray_unittest.cc View 9 chunks +1 line, -26 lines 0 comments Download
M ash/test/content/test_shell_content_state.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/test/test_shell_delegate.cc View 2 chunks +1 line, -4 lines 0 comments Download
M ash/tooltips/tooltip_controller_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ash/touch/touch_observer_hud.h View 1 2 3 chunks +1 line, -8 lines 0 comments Download
M ash/touch/touch_observer_hud.cc View 1 2 2 chunks +0 lines, -8 lines 0 comments Download
M ash/touch/touch_observer_hud_unittest.cc View 5 chunks +5 lines, -35 lines 0 comments Download
M ash/utility/screenshot_controller_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/wm/ash_native_cursor_manager.cc View 4 chunks +4 lines, -13 lines 0 comments Download
M ash/wm/immersive_fullscreen_controller_unittest.cc View 3 chunks +1 line, -16 lines 0 comments Download
M ash/wm/lock_state_controller.cc View 6 chunks +3 lines, -18 lines 0 comments Download
M ash/wm/lock_state_controller_unittest.cc View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 3 chunks +1 line, -10 lines 0 comments Download
M ash/wm/panels/panel_window_resizer_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/wm/power_button_controller.h View 1 2 5 chunks +3 lines, -20 lines 0 comments Download
M ash/wm/power_button_controller.cc View 1 2 8 chunks +4 lines, -21 lines 0 comments Download
M ash/wm/screen_dimmer_unittest.cc View 1 chunk +1 line, -7 lines 0 comments Download
M ash/wm/system_gesture_event_filter.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/wm/toplevel_window_event_handler_unittest.cc View 3 chunks +2 lines, -21 lines 0 comments Download
M ash/wm/window_manager_unittest.cc View 4 chunks +3 lines, -13 lines 0 comments Download
M ash/wm/window_positioner_unittest.cc View 3 chunks +2 lines, -11 lines 0 comments Download
M ash/wm/workspace/workspace_event_handler_unittest.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 1 chunk +1 line, -7 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 3 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
James Cook
oshima, please take a look. This change is mostly mechanical. I checked all the bugs ...
3 years, 11 months ago (2017-01-07 01:14:51 UTC) #4
oshima
On 2017/01/07 01:14:51, James Cook wrote: > oshima, please take a look. This change is ...
3 years, 11 months ago (2017-01-09 18:44:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618143002/40001
3 years, 11 months ago (2017-01-09 19:16:15 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 19:58:46 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/01bf23e7e27102560b44f1353d8f...

Powered by Google App Engine
This is Rietveld 408576698