Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2835)

Unified Diff: ash/wm/lock_state_controller.cc

Issue 2618143002: cros: Remove some OS platform ifdefs from ash (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/immersive_fullscreen_controller_unittest.cc ('k') | ash/wm/lock_state_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/lock_state_controller.cc
diff --git a/ash/wm/lock_state_controller.cc b/ash/wm/lock_state_controller.cc
index c4f40ee3c744636b0968aee286abc49d204c696a..31a874d1583cc4d34e7b6034f799abb46c97b8ec 100644
--- a/ash/wm/lock_state_controller.cc
+++ b/ash/wm/lock_state_controller.cc
@@ -25,17 +25,14 @@
#include "base/logging.h"
#include "base/metrics/histogram_macros.h"
#include "base/strings/string_util.h"
+#include "base/sys_info.h"
#include "base/timer/timer.h"
+#include "chromeos/dbus/dbus_thread_manager.h"
+#include "chromeos/dbus/session_manager_client.h"
#include "ui/aura/window_tree_host.h"
#include "ui/views/controls/menu/menu_controller.h"
#include "ui/wm/core/compound_event_filter.h"
-#if defined(OS_CHROMEOS)
-#include "base/sys_info.h"
-#include "chromeos/dbus/dbus_thread_manager.h"
-#include "chromeos/dbus/session_manager_client.h"
-#endif
-
#define UMA_HISTOGRAM_LOCK_TIMES(name, sample) \
UMA_HISTOGRAM_CUSTOM_TIMES(name, sample, \
base::TimeDelta::FromMilliseconds(1), \
@@ -45,9 +42,7 @@ namespace ash {
namespace {
-#if defined(OS_CHROMEOS)
const int kMaxShutdownSoundDurationMs = 1500;
-#endif
} // namespace
@@ -57,10 +52,6 @@ const int kMaxShutdownSoundDurationMs = 1500;
// For MSan the slowdown depends heavily on the value of msan_track_origins GYP
// flag. The multiplier below corresponds to msan_track_origins=1.
static const int kTimeoutMultiplier = 6;
-#elif defined(ADDRESS_SANITIZER) && defined(OS_WIN)
-// Asan/Win has not been optimized yet, give it a higher
-// timeout multiplier. See http://crbug.com/412471
-static const int kTimeoutMultiplier = 3;
#elif defined(ADDRESS_SANITIZER) || defined(THREAD_SANITIZER) || \
defined(SYZYASAN)
static const int kTimeoutMultiplier = 2;
@@ -293,14 +284,12 @@ void LockStateController::StartRealShutdownTimer(bool with_animation_time) {
animator_->GetDuration(SessionStateAnimator::ANIMATION_SPEED_SHUTDOWN);
}
-#if defined(OS_CHROMEOS)
base::TimeDelta sound_duration =
WmShell::Get()->accessibility_delegate()->PlayShutdownSound();
sound_duration =
std::min(sound_duration,
base::TimeDelta::FromMilliseconds(kMaxShutdownSoundDurationMs));
duration = std::max(duration, sound_duration);
-#endif
real_shutdown_timer_.Start(
FROM_HERE, duration, base::Bind(&LockStateController::OnRealPowerTimeout,
@@ -477,16 +466,13 @@ void LockStateController::PreLockAnimationFinished(bool request_lock) {
WmShell::Get()->RecordUserMetricsAction(
shutdown_after_lock_ ? UMA_ACCEL_LOCK_SCREEN_POWER_BUTTON
: UMA_ACCEL_LOCK_SCREEN_LOCK_BUTTON);
-#if defined(OS_CHROMEOS)
chromeos::DBusThreadManager::Get()
->GetSessionManagerClient()
->RequestLockScreen();
-#endif
}
base::TimeDelta timeout =
base::TimeDelta::FromMilliseconds(kLockFailTimeoutMs);
-#if defined(OS_CHROMEOS)
// Increase lock timeout for slower hardware, see http://crbug.com/350628
// The devices with boards "x86-mario", "daisy", "x86-alex" and "x86-zgb" have
// slower hardware. For "x86-alex" and "x86-zgb" there are some modifications
@@ -498,7 +484,6 @@ void LockStateController::PreLockAnimationFinished(bool request_lock) {
base::StartsWith(board, "x86-zgb", base::CompareCase::SENSITIVE)) {
timeout *= 2;
}
-#endif
lock_fail_timer_.Start(FROM_HERE, timeout, this,
&LockStateController::OnLockFailTimeout);
« no previous file with comments | « ash/wm/immersive_fullscreen_controller_unittest.cc ('k') | ash/wm/lock_state_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698