GRIT: put <if> and <include> behind comments in .js files to make syntactically valid JS

GRIT: put <if> and <include> behind comments in .js files to make syntactically valid JS

This unblocks clang-format on .js files. See bug for more details.

R=thakis@chromium.org,hirono@chromium.org,xiyuan@chromium.org
TBR=jam@chromium.org
BUG=678778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2617823002
Cr-Commit-Position: refs/heads/master@{#442322}
Committed: https://chromium.googlesource.com/chromium/src/+/94146b3fa89acb43b24182b30258f3fb5bb62047

[Dan Beam, 2017-01-05 22:31:10]

Description was changed from

==========
Comment out <if> and <include> in .js files

R=thakis@chromium.org
BUG=678778
==========

to

==========
Comment out <if> and <include> in .js files

R=thakis@chromium.org
BUG=678778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-01-05 22:41:39]

Patchset #2 (id:20001) has been deleted

[Dan Beam, 2017-01-05 22:41:45]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2017-01-05 22:41:54]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[Dan Beam, 2017-01-05 22:42:13]

Description was changed from

==========
Comment out <if> and <include> in .js files

R=thakis@chromium.org
BUG=678778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Comment out <if> and <include> in .js files

R=jam@chromium.org
BUG=678778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-01-05 22:42:13]

dbeam@chromium.org changed reviewers:
+ jam@chromium.org
- thakis@chromium.org

[commit-bot: I haz the power, 2017-01-05 22:42:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-01-05 22:42:38]

Description was changed from

==========
Comment out <if> and <include> in .js files

R=jam@chromium.org
BUG=678778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
GRIT: put <if> and <include> behind comments in .js files to make syntactically
valid JS

R=jam@chromium.org
BUG=678778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-01-05 22:45:25]

Patchset #1 (id:40001) has been deleted

[Dan Beam, 2017-01-05 22:45:33]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[Dan Beam, 2017-01-05 22:45:54]

Description was changed from

==========
GRIT: put <if> and <include> behind comments in .js files to make syntactically
valid JS

R=jam@chromium.org
BUG=678778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
GRIT: put <if> and <include> behind comments in .js files to make syntactically
valid JS

This unblocks clang-format on .js files. See bug for more details.

R=jam@chromium.org
BUG=678778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2017-01-05 22:46:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-01-05 23:34:24]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-01-05 23:34:24]

+c/b/resources/chromeos/OWNERS for their information. The motivation is to make
our .js files actually syntactically valid .js files.

[Nico, 2017-01-05 23:36:21]

+ui/file_manager/OWNERS as well.

again, the motivation is to make our .js files actually syntactically valid .js
files by moving grit statements into comments (where they still take effect)

[xiyuan, 2017-01-05 23:43:29]

xiyuan@chromium.org changed reviewers:
+ xiyuan@chromium.org

[xiyuan, 2017-01-05 23:43:30]

Would GRIT expand the included file behind the "//" ?

[commit-bot: I haz the power, 2017-01-06 00:06:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 00:06:40]

Dry run: This issue passed the CQ dry run.

[hirono, 2017-01-06 01:48:09]

hirono@chromium.org changed reviewers:
+ hirono@chromium.org

[hirono, 2017-01-06 01:48:10]

lgtm for ui/file_manager

[Dan Beam, 2017-01-06 02:56:47]

On 2017/01/05 23:43:30, xiyuan wrote:
> Would GRIT expand the included file behind the "//" ?

GRIT expands the file.  currently we rely on a copyright to be on the first line
of each file, as enforced by our tooling.

There are examples of the GRIT expanded output in the tests I added as a
dependency to this CL:
https://codereview.chromium.org/2615953002/diff/20001/tools/grit/grit/format/...

[xiyuan, 2017-01-06 16:59:43]

On 2017/01/06 02:56:47, Dan Beam wrote:
> On 2017/01/05 23:43:30, xiyuan wrote:
> > Would GRIT expand the included file behind the "//" ?
> 
> GRIT expands the file.  currently we rely on a copyright to be on the first
line
> of each file, as enforced by our tooling.
> 
> There are examples of the GRIT expanded output in the tests I added as a
> dependency to this CL:
>
https://codereview.chromium.org/2615953002/diff/20001/tools/grit/grit/format/...

Thanks for the clarification. lgtm then.

[jam, 2017-01-06 17:02:12]

Which files do you want me to look at?

[Dan Beam, 2017-01-06 18:50:04]

On 2017/01/06 17:02:12, jam wrote:
> Which files do you want me to look at?

kinda just need a sec/OWNERS stamp

[Dan Beam, 2017-01-06 18:50:30]

On 2017/01/06 18:50:04, Dan Beam wrote:
> On 2017/01/06 17:02:12, jam wrote:
> > Which files do you want me to look at?
> 
> kinda just need a sec/OWNERS stamp

src/OWNERS

[jam, 2017-01-06 20:38:00]

On 2017/01/06 18:50:30, Dan Beam wrote:
> On 2017/01/06 18:50:04, Dan Beam wrote:
> > On 2017/01/06 17:02:12, jam wrote:
> > > Which files do you want me to look at?
> > 
> > kinda just need a sec/OWNERS stamp
> 
> src/OWNERS

src/owners is really for adding new directories. for changes like this, please
ask owners of chrome and ui

[Dan Beam, 2017-01-06 22:05:02]

On 2017/01/06 20:38:00, jam wrote:
> On 2017/01/06 18:50:30, Dan Beam wrote:
> > On 2017/01/06 18:50:04, Dan Beam wrote:
> > > On 2017/01/06 17:02:12, jam wrote:
> > > > Which files do you want me to look at?
> > > 
> > > kinda just need a sec/OWNERS stamp
> > 
> > src/OWNERS
> 
> src/owners is really for adding new directories. for changes like this, please
> ask owners of chrome and ui

Nico, can I get a ui/ and chrome/ stamp?

[Nico, 2017-01-09 15:15:44]

lgtm

[Dan Beam, 2017-01-09 18:11:06]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 18:11:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-01-09 19:21:46]

The CQ bit was unchecked by dbeam@chromium.org

[Dan Beam, 2017-01-09 19:22:00]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2017-01-09 19:22:27]

Description was changed from

==========
GRIT: put <if> and <include> behind comments in .js files to make syntactically
valid JS

This unblocks clang-format on .js files. See bug for more details.

R=jam@chromium.org
BUG=678778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
GRIT: put <if> and <include> behind comments in .js files to make syntactically
valid JS

This unblocks clang-format on .js files. See bug for more details.

R=thakis@chromium.org,hirono@chromium.org,xiyuan@chromium.org
BUG=678778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2017-01-09 19:22:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 19:43:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 19:43:58]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Dan Beam, 2017-01-09 19:53:31]

Description was changed from

==========
GRIT: put <if> and <include> behind comments in .js files to make syntactically
valid JS

This unblocks clang-format on .js files. See bug for more details.

R=thakis@chromium.org,hirono@chromium.org,xiyuan@chromium.org
BUG=678778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
GRIT: put <if> and <include> behind comments in .js files to make syntactically
valid JS

This unblocks clang-format on .js files. See bug for more details.

R=thakis@chromium.org,hirono@chromium.org,xiyuan@chromium.org
TBR=jam@chromium.org
BUG=678778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-01-09 19:54:56]

On 2017/01/09 19:43:58, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

TBR=jam for these files:
    components/neterror/resources/neterror.js
    components/security_interstitials/core/browser/resources/interstitial_v2.js
    content/browser/resources/gpu/gpu_internals.js
    content/browser/resources/media/media_internals.js
    content/browser/resources/media/stats_graph_helper.js
    content/browser/resources/media/webrtc_internals.js

[Dan Beam, 2017-01-09 19:55:08]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-01-09 19:55:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 20:16:46]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483991708789270,
"parent_rev": "7dcb520819f004e4751051a6cc6181b717b211b1", "commit_rev":
"94146b3fa89acb43b24182b30258f3fb5bb62047"}

[commit-bot: I haz the power, 2017-01-09 20:17:29]

Description was changed from

==========
GRIT: put <if> and <include> behind comments in .js files to make syntactically
valid JS

This unblocks clang-format on .js files. See bug for more details.

R=thakis@chromium.org,hirono@chromium.org,xiyuan@chromium.org
TBR=jam@chromium.org
BUG=678778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
GRIT: put <if> and <include> behind comments in .js files to make syntactically
valid JS

This unblocks clang-format on .js files. See bug for more details.

R=thakis@chromium.org,hirono@chromium.org,xiyuan@chromium.org
TBR=jam@chromium.org
BUG=678778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2617823002
Cr-Commit-Position: refs/heads/master@{#442322}
Committed:
https://chromium.googlesource.com/chromium/src/+/94146b3fa89acb43b24182b30258...
==========

[commit-bot: I haz the power, 2017-01-09 20:17:32]

Committed patchset #1 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/94146b3fa89acb43b24182b30258...