Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4326)

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page.js

Issue 2617823002: GRIT: put <if> and <include> behind comments in .js files to make syntactically valid JS (Closed)
Patch Set: add dep Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/privacy_page/privacy_page.js
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.js b/chrome/browser/resources/settings/privacy_page/privacy_page.js
index f497f759b161724a065fcdfdf6b385d8bf46e437..ae72e250ac670b7f265a5639371cb776c57d1ccd 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.js
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.js
@@ -30,12 +30,12 @@ Polymer({
*/
pageVisibility: Object,
-<if expr="_google_chrome and not chromeos">
+// <if expr="_google_chrome and not chromeos">
/** @type {MetricsReporting} */
metricsReporting_: Object,
showRestart_: Boolean,
-</if>
+// </if>
/** @private */
safeBrowsingExtendedReportingEnabled_: Boolean,
@@ -47,13 +47,13 @@ Polymer({
ready: function() {
this.ContentSettingsTypes = settings.ContentSettingsTypes;
-<if expr="_google_chrome and not chromeos">
+// <if expr="_google_chrome and not chromeos">
var boundSetMetricsReporting = this.setMetricsReporting_.bind(this);
this.addWebUIListener('metrics-reporting-change', boundSetMetricsReporting);
var browserProxy = settings.PrivacyPageBrowserProxyImpl.getInstance();
browserProxy.getMetricsReporting().then(boundSetMetricsReporting);
-</if>
+// </if>
var boundSetSber = this.setSafeBrowsingExtendedReporting_.bind(this);
this.addWebUIListener('safe-browsing-extended-reporting-change',
@@ -70,13 +70,13 @@ Polymer({
/** @private */
onManageCertificatesTap_: function() {
-<if expr="use_nss_certs">
+// <if expr="use_nss_certs">
settings.navigateTo(settings.Route.CERTIFICATES);
-</if>
-<if expr="is_win or is_macosx">
+// </if>
+// <if expr="is_win or is_macosx">
settings.PrivacyPageBrowserProxyImpl.getInstance().
showManageSSLCertificates();
-</if>
+// </if>
},
/**
@@ -111,7 +111,7 @@ Polymer({
'https://support.google.com/chrome/?p=settings_manage_exceptions');
},
-<if expr="_google_chrome and not chromeos">
+// <if expr="_google_chrome and not chromeos">
/** @private */
onMetricsReportingCheckboxTap_: function() {
var browserProxy = settings.PrivacyPageBrowserProxyImpl.getInstance();
@@ -139,7 +139,7 @@ Polymer({
onRestartTap_: function() {
settings.LifetimeBrowserProxyImpl.getInstance().restart();
},
-</if>
+// </if>
/** @private */
onSafeBrowsingExtendedReportingCheckboxTap_: function() {
@@ -166,11 +166,11 @@ Polymer({
loadTimeData.getString('contentSettings');
},
-<if expr="chromeos">
+// <if expr="chromeos">
/** @private */
onAdobeFlashStorageClicked_: function() {
window.open('https://www.macromedia.com/support/' +
'documentation/en/flashplayer/help/settings_manager07.html');
},
-</if>
+// </if>
});

Powered by Google App Engine
This is Rietveld 408576698