Fix grit's <if> not to strip trailing or preceding whitespace

Fix grit's <if> not to strip trailing or preceding whitespace

This is so a single line comment can be used to exclude <if> in .js
files. I've added tests for both <include> and <if>. They need to be
commented for clang-format purposes.

BUG=678778
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2615953002
Cr-Commit-Position: refs/heads/master@{#441853}
Committed: https://chromium.googlesource.com/chromium/src/+/42fdc659ccc288d4a3a01f202c7d667e76b04192

[Dan Beam, 2017-01-05 21:55:44]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 21:56:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-01-05 22:00:05]

lgtm with comments, but I'd file a dedicated "put grit statements in js files in
comments" bug, BUG= this CL to that, and mark the BUG that you did link to
blocked on that new bug

https://codereview.chromium.org/2615953002/diff/1/tools/grit/grit/format/html...
File tools/grit/grit/format/html_inline_unittest.py (right):

https://codereview.chromium.org/2615953002/diff/1/tools/grit/grit/format/html...
tools/grit/grit/format/html_inline_unittest.py:448: '''Tests that commenting out
an <include> works predictably.'''
I'd phrase that as "tests that <include> works in a comment too"; as-is it reads
to me as if an <include> could be commented out and would then not work.

https://codereview.chromium.org/2615953002/diff/1/tools/grit/grit/format/html...
tools/grit/grit/format/html_inline_unittest.py:470: '''Tests that commenting out
an <include> works predictably.'''
same comment, also s/include/if/ here

[commit-bot: I haz the power, 2017-01-05 22:07:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 22:08:00]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2017-01-05 22:11:54]

Description was changed from

==========
Fix grit's <if> not to strip trailing or preceding whitespace

This is so a single line comment can be used to exclude <if> in .js
files. I've added tests for both <include> and <if>. They need to be
commented for clang-format purposes.

BUG=567770
R=thakis@chromium.org
==========

to

==========
Fix grit's <if> not to strip trailing or preceding whitespace

This is so a single line comment can be used to exclude <if> in .js
files. I've added tests for both <include> and <if>. They need to be
commented for clang-format purposes.

BUG=678778
R=thakis@chromium.org
==========

[Dan Beam, 2017-01-05 22:25:41]

https://codereview.chromium.org/2615953002/diff/1/tools/grit/grit/format/html...
File tools/grit/grit/format/html_inline_unittest.py (right):

https://codereview.chromium.org/2615953002/diff/1/tools/grit/grit/format/html...
tools/grit/grit/format/html_inline_unittest.py:448: '''Tests that commenting out
an <include> works predictably.'''
On 2017/01/05 22:00:05, Nico (ooo sick) wrote:
> I'd phrase that as "tests that <include> works in a comment too"; as-is it
reads
> to me as if an <include> could be commented out and would then not work.

Done.

https://codereview.chromium.org/2615953002/diff/1/tools/grit/grit/format/html...
tools/grit/grit/format/html_inline_unittest.py:470: '''Tests that commenting out
an <include> works predictably.'''
On 2017/01/05 22:00:05, Nico (ooo sick) wrote:
> same comment, also s/include/if/ here

Done.

[Dan Beam, 2017-01-05 22:25:45]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2017-01-05 22:25:45]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2615953002/#ps20001
(title: "indent tweak and comment fixes for thakis@")

[commit-bot: I haz the power, 2017-01-05 22:26:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 02:53:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483655145119720,
"parent_rev": "5ec4db1337f3b37ec09824e8b12a1051646098be", "commit_rev":
"42fdc659ccc288d4a3a01f202c7d667e76b04192"}

[commit-bot: I haz the power, 2017-01-06 02:53:32]

Description was changed from

==========
Fix grit's <if> not to strip trailing or preceding whitespace

This is so a single line comment can be used to exclude <if> in .js
files. I've added tests for both <include> and <if>. They need to be
commented for clang-format purposes.

BUG=678778
R=thakis@chromium.org
==========

to

==========
Fix grit's <if> not to strip trailing or preceding whitespace

This is so a single line comment can be used to exclude <if> in .js
files. I've added tests for both <include> and <if>. They need to be
commented for clang-format purposes.

BUG=678778
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2615953002
Cr-Commit-Position: refs/heads/master@{#441853}
Committed:
https://chromium.googlesource.com/chromium/src/+/42fdc659ccc288d4a3a01f202c7d...
==========

[commit-bot: I haz the power, 2017-01-06 02:53:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/42fdc659ccc288d4a3a01f202c7d...