Migrate WTF::Vector::append() to ::push_back() [part 12 of N]

Migrate WTF::Vector::append() to ::push_back() [part 12 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/svg, timing,
workers, and xml.

There are too many references to change them all at once, so this CL is
part 12 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2617783002
Cr-Commit-Position: refs/heads/master@{#442267}
Committed: https://chromium.googlesource.com/chromium/src/+/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1

[pilgrim_google, 2017-01-05 21:32:20]

Description was changed from

==========
Migrate WTF::Vector::append() to ::push_back() [part 12 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/svg, timing,
workers, and xml.

There are too many references to change them all at once, so this CL is
part 12 of many.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
==========

to

==========
Migrate WTF::Vector::append() to ::push_back() [part 12 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/svg, timing,
workers, and xml.

There are too many references to change them all at once, so this CL is
part 12 of many.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pilgrim_google, 2017-01-05 21:47:23]

The CQ bit was checked by pilgrim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 21:48:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pilgrim_google, 2017-01-05 21:51:37]

pilgrim@chromium.org changed reviewers:
+ esprehn@chromium.org, haraken@chromium.org, yutak@chromium.org

[haraken, 2017-01-05 23:11:20]

LGTM

[commit-bot: I haz the power, 2017-01-05 23:42:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 23:42:46]

Dry run: This issue passed the CQ dry run.

[pilgrim_google, 2017-01-06 02:16:23]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2017-01-06 02:17:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 02:24:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 02:24:16]

Failed to apply patch for
third_party/WebKit/Source/core/timing/PerformanceBase.cpp:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/core/timing/PerformanceBase.cpp:141
  error: third_party/WebKit/Source/core/timing/PerformanceBase.cpp: patch does
not apply

Patch:       third_party/WebKit/Source/core/timing/PerformanceBase.cpp
Index: third_party/WebKit/Source/core/timing/PerformanceBase.cpp
diff --git a/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
b/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
index
aa49b288243b451cf35a4f9024895baed6f96337..5905b15287984171eed492a1e9b19c2d13d3c32f
100644
--- a/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
+++ b/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
@@ -113,7 +113,7 @@ PerformanceEntryVector PerformanceBase::getEntries() const {
 
   entries.appendVector(m_resourceTimingBuffer);
   if (m_navigationTiming)
-    entries.append(m_navigationTiming);
+    entries.push_back(m_navigationTiming);
   entries.appendVector(m_frameTimingBuffer);
 
   if (m_userTiming) {
@@ -141,17 +141,17 @@ PerformanceEntryVector PerformanceBase::getEntriesByType(
       return entries;
     case PerformanceEntry::Resource:
       for (const auto& resource : m_resourceTimingBuffer)
-        entries.append(resource);
+        entries.push_back(resource);
       break;
     case PerformanceEntry::Navigation:
       if (m_navigationTiming)
-        entries.append(m_navigationTiming);
+        entries.push_back(m_navigationTiming);
       break;
     case PerformanceEntry::Composite:
     case PerformanceEntry::Render:
       for (const auto& frame : m_frameTimingBuffer) {
         if (type == frame->entryTypeEnum()) {
-          entries.append(frame);
+          entries.push_back(frame);
         }
       }
       break;
@@ -183,13 +183,13 @@ PerformanceEntryVector PerformanceBase::getEntriesByName(
   if (entryType.isNull() || type == PerformanceEntry::Resource) {
     for (const auto& resource : m_resourceTimingBuffer) {
       if (resource->name() == name)
-        entries.append(resource);
+        entries.push_back(resource);
     }
   }
 
   if (entryType.isNull() || type == PerformanceEntry::Navigation) {
     if (m_navigationTiming && m_navigationTiming->name() == name)
-      entries.append(m_navigationTiming);
+      entries.push_back(m_navigationTiming);
   }
 
   if (entryType.isNull() || type == PerformanceEntry::Composite ||
@@ -197,7 +197,7 @@ PerformanceEntryVector PerformanceBase::getEntriesByName(
     for (const auto& frame : m_frameTimingBuffer) {
       if (frame->name() == name &&
           (entryType.isNull() || entryType == frame->entryType()))
-        entries.append(frame);
+        entries.push_back(frame);
     }
   }
 
@@ -401,7 +401,7 @@ void PerformanceBase::addNavigationTiming(LocalFrame* frame)
{
 }
 
 void PerformanceBase::addResourceTimingBuffer(PerformanceEntry& entry) {
-  m_resourceTimingBuffer.append(&entry);
+  m_resourceTimingBuffer.push_back(&entry);
 
   if (isResourceTimingBufferFull()) {
     dispatchEvent(Event::create(EventTypeNames::resourcetimingbufferfull));
@@ -415,7 +415,7 @@ bool PerformanceBase::isResourceTimingBufferFull() {
 }
 
 void PerformanceBase::addFrameTimingBuffer(PerformanceEntry& entry) {
-  m_frameTimingBuffer.append(&entry);
+  m_frameTimingBuffer.push_back(&entry);
 
   if (isFrameTimingBufferFull())
     dispatchEvent(Event::create(EventTypeNames::frametimingbufferfull));

[pilgrim_google, 2017-01-06 14:38:57]

The CQ bit was checked by pilgrim@chromium.org

[pilgrim_google, 2017-01-06 14:38:58]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2617783002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-06 14:39:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 16:41:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 16:41:06]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[pilgrim_google, 2017-01-09 15:00:18]

The CQ bit was checked by pilgrim@chromium.org

[pilgrim_google, 2017-01-09 15:00:18]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2617783002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-09 15:00:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 16:48:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483974018329280,
"parent_rev": "2dfd0cfada562629f52da5d920f679ecc94e0e31", "commit_rev":
"e23ac2114da2a67a3e62e29eebd8f9192c83e8d1"}

[commit-bot: I haz the power, 2017-01-09 16:49:27]

Description was changed from

==========
Migrate WTF::Vector::append() to ::push_back() [part 12 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/svg, timing,
workers, and xml.

There are too many references to change them all at once, so this CL is
part 12 of many.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Migrate WTF::Vector::append() to ::push_back() [part 12 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/svg, timing,
workers, and xml.

There are too many references to change them all at once, so this CL is
part 12 of many.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2617783002
Cr-Commit-Position: refs/heads/master@{#442267}
Committed:
https://chromium.googlesource.com/chromium/src/+/e23ac2114da2a67a3e62e29eebd8...
==========

[commit-bot: I haz the power, 2017-01-09 16:49:28]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e23ac2114da2a67a3e62e29eebd8...