Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp

Issue 2617783002: Migrate WTF::Vector::append() to ::push_back() [part 12 of N] (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
diff --git a/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp b/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
index 08ae8d839e8db64720c0eb426a64daaa13fdf15d..78ac9997ac67ec5fa01482e22b802f37df0c81e2 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
+++ b/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
@@ -129,7 +129,7 @@ TEST_F(PerformanceBaseTest, AddLongTaskTiming) {
NonThrowableExceptionState exceptionState;
PerformanceObserverInit options;
Vector<String> entryTypeVec;
- entryTypeVec.append("longtask");
+ entryTypeVec.push_back("longtask");
options.setEntryTypes(entryTypeVec);
m_observer->observe(options, exceptionState);
@@ -171,8 +171,8 @@ TEST_F(PerformanceBaseTest, AllowsTimingRedirect) {
redirectResponse1.setURL(url);
ResourceResponse redirectResponse2;
redirectResponse2.setURL(url);
- redirectChain.append(redirectResponse1);
- redirectChain.append(redirectResponse2);
+ redirectChain.push_back(redirectResponse1);
+ redirectChain.push_back(redirectResponse2);
RefPtr<SecurityOrigin> securityOrigin = SecurityOrigin::create(url);
EXPECT_TRUE(allowsTimingRedirect(redirectChain, finalResponse,
*securityOrigin.get(),
@@ -182,7 +182,7 @@ TEST_F(PerformanceBaseTest, AllowsTimingRedirect) {
KURL redirectUrl(ParsedURLString, crossOriginDomain + "/bar.html");
ResourceResponse redirectResponse3;
redirectResponse3.setURL(redirectUrl);
- redirectChain.append(redirectResponse3);
+ redirectChain.push_back(redirectResponse3);
EXPECT_FALSE(allowsTimingRedirect(redirectChain, finalResponse,
*securityOrigin.get(),
getExecutionContext()));

Powered by Google App Engine
This is Rietveld 408576698