Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1667)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceBase.cpp

Issue 2617783002: Migrate WTF::Vector::append() to ::push_back() [part 12 of N] (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceBase.cpp
diff --git a/third_party/WebKit/Source/core/timing/PerformanceBase.cpp b/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
index 660507eee11d03eae3d5bff86da2a268791a26b1..78da775f3d4b18387142ce991e48a0c434037382 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
+++ b/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
@@ -113,7 +113,7 @@ PerformanceEntryVector PerformanceBase::getEntries() const {
entries.appendVector(m_resourceTimingBuffer);
if (m_navigationTiming)
- entries.append(m_navigationTiming);
+ entries.push_back(m_navigationTiming);
entries.appendVector(m_frameTimingBuffer);
if (m_userTiming) {
@@ -135,17 +135,17 @@ PerformanceEntryVector PerformanceBase::getEntriesByType(
switch (type) {
case PerformanceEntry::Resource:
for (const auto& resource : m_resourceTimingBuffer)
- entries.append(resource);
+ entries.push_back(resource);
break;
case PerformanceEntry::Navigation:
if (m_navigationTiming)
- entries.append(m_navigationTiming);
+ entries.push_back(m_navigationTiming);
break;
case PerformanceEntry::Composite:
case PerformanceEntry::Render:
for (const auto& frame : m_frameTimingBuffer) {
if (type == frame->entryTypeEnum()) {
- entries.append(frame);
+ entries.push_back(frame);
}
}
break;
@@ -186,13 +186,13 @@ PerformanceEntryVector PerformanceBase::getEntriesByName(
if (entryType.isNull() || type == PerformanceEntry::Resource) {
for (const auto& resource : m_resourceTimingBuffer) {
if (resource->name() == name)
- entries.append(resource);
+ entries.push_back(resource);
}
}
if (entryType.isNull() || type == PerformanceEntry::Navigation) {
if (m_navigationTiming && m_navigationTiming->name() == name)
- entries.append(m_navigationTiming);
+ entries.push_back(m_navigationTiming);
}
if (entryType.isNull() || type == PerformanceEntry::Composite ||
@@ -200,7 +200,7 @@ PerformanceEntryVector PerformanceBase::getEntriesByName(
for (const auto& frame : m_frameTimingBuffer) {
if (frame->name() == name &&
(entryType.isNull() || entryType == frame->entryType()))
- entries.append(frame);
+ entries.push_back(frame);
}
}
@@ -404,7 +404,7 @@ void PerformanceBase::addNavigationTiming(LocalFrame* frame) {
}
void PerformanceBase::addResourceTimingBuffer(PerformanceEntry& entry) {
- m_resourceTimingBuffer.append(&entry);
+ m_resourceTimingBuffer.push_back(&entry);
if (isResourceTimingBufferFull()) {
dispatchEvent(Event::create(EventTypeNames::resourcetimingbufferfull));
@@ -418,7 +418,7 @@ bool PerformanceBase::isResourceTimingBufferFull() {
}
void PerformanceBase::addFrameTimingBuffer(PerformanceEntry& entry) {
- m_frameTimingBuffer.append(&entry);
+ m_frameTimingBuffer.push_back(&entry);
if (isFrameTimingBufferFull())
dispatchEvent(Event::create(EventTypeNames::frametimingbufferfull));

Powered by Google App Engine
This is Rietveld 408576698