Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issue 2611123004: Combine {Legacy,}StyleInterpolation.h (Closed)

Created:
3 years, 11 months ago by suzyh_UTC10 (ex-contributor)
Modified:
3 years, 11 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Combine {Legacy,}StyleInterpolation.h This patch merges StyleInterpolation.h and LegacyStyleInterpolation.h in preparation for removing the distinction between the two classes. There is no behavioral change introduced by this patch. BUG=678875 Review-Url: https://codereview.chromium.org/2611123004 Cr-Commit-Position: refs/heads/master@{#442195} Committed: https://chromium.googlesource.com/chromium/src/+/9c06cb4534c62659b48895b0dde92af653d32d88

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -56 lines) Patch
M third_party/WebKit/Source/core/animation/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/LegacyStyleInterpolation.h View 1 chunk +38 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/animation/StyleInterpolation.h View 1 chunk +0 lines, -52 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (13 generated)
suzyh_UTC10 (ex-contributor)
3 years, 11 months ago (2017-01-06 03:40:18 UTC) #3
alancutter (OOO until 2018)
lgtm
3 years, 11 months ago (2017-01-09 00:44:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611123004/1
3 years, 11 months ago (2017-01-09 03:10:36 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/337147)
3 years, 11 months ago (2017-01-09 03:17:08 UTC) #13
suzyh_UTC10 (ex-contributor)
+sashab for core/css
3 years, 11 months ago (2017-01-09 03:23:18 UTC) #15
sashab
StyleResolver.cpp lgtm
3 years, 11 months ago (2017-01-09 03:50:00 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611123004/1
3 years, 11 months ago (2017-01-09 04:01:27 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 04:36:26 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9c06cb4534c62659b48895b0dde9...

Powered by Google App Engine
This is Rietveld 408576698