The great shader refactor: Merge all vertex shaders

The great shader refactor: Merge all vertex shaders

There are lots of idiosyncracies here, particularly with respect to
texture coordinate transformations.

This makes an effort to change no behavior, including cargo-culting
all of the dummy variables.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2617673002
Cr-Commit-Position: refs/heads/master@{#442359}
Committed: https://chromium.googlesource.com/chromium/src/+/f65aa1847f78fb5a5d944723de974906e987f544

[ccameron, 2017-01-05 02:47:21]

Description was changed from

==========
The great shader refactor: Merge all vertex shaders

There are lots of idiosyncracies here, particularly with respect to
texture coordinate transformations.

This makes an effort to change no behavior, including cargo-culting
all of the dummy variables.

BUG=667966
==========

to

==========
The great shader refactor: Merge all vertex shaders

There are lots of idiosyncracies here, particularly with respect to
texture coordinate transformations.

This makes an effort to change no behavior, including cargo-culting
all of the dummy variables.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-01-05 02:47:22]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 02:47:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 03:46:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 03:46:52]

Dry run: This issue passed the CQ dry run.

[ccameron, 2017-01-05 03:54:07]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 03:54:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-01-05 04:02:41]

ccameron@chromium.org changed reviewers:
+ enne@chromium.org

[ccameron, 2017-01-05 04:02:41]

Same scheme as before ...

This non-holiday season I want to give thanks for unittests. They make
refactoring fearless.

[commit-bot: I haz the power, 2017-01-05 05:43:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 05:43:28]

Dry run: This issue passed the CQ dry run.

[enne (OOO), 2017-01-09 19:39:03]

lgtm


> This non-holiday season I want to give thanks for unittests. They make
refactoring fearless.

Welllll, we at least have compilation tests for all shaders.  I'm less confident
on our coverage of their content.  Out of curiosity, which ones have been
serving you well?

[ccameron, 2017-01-09 20:31:08]

On 2017/01/09 19:39:03, enne wrote:
> lgtm
> 
> 
> > This non-holiday season I want to give thanks for unittests. They make
> refactoring fearless.
> 
> Welllll, we at least have compilation tests for all shaders.  I'm less
confident
> on our coverage of their content.  Out of curiosity, which ones have been
> serving you well?

[ccameron, 2017-01-09 20:31:58]

On 2017/01/09 19:39:03, enne wrote:
> lgtm
> 
> 
> > This non-holiday season I want to give thanks for unittests. They make
> refactoring fearless.
> 
> Welllll, we at least have compilation tests for all shaders.  I'm less
confident
> on our coverage of their content.  Out of curiosity, which ones have been
> serving you well?

We do have some pixel tests! I did go and manually verify that "if I make the
shaders compile correctly but output red, we still get pixel mismatches".

I don't know when they were added, but I'm a fan!

[ccameron, 2017-01-09 20:32:04]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-01-09 20:33:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 21:38:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483993924668360,
"parent_rev": "5152412748d516c473277f32593ac9a9ddc585a4", "commit_rev":
"f65aa1847f78fb5a5d944723de974906e987f544"}

[commit-bot: I haz the power, 2017-01-09 21:39:08]

Description was changed from

==========
The great shader refactor: Merge all vertex shaders

There are lots of idiosyncracies here, particularly with respect to
texture coordinate transformations.

This makes an effort to change no behavior, including cargo-culting
all of the dummy variables.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
The great shader refactor: Merge all vertex shaders

There are lots of idiosyncracies here, particularly with respect to
texture coordinate transformations.

This makes an effort to change no behavior, including cargo-culting
all of the dummy variables.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2617673002
Cr-Commit-Position: refs/heads/master@{#442359}
Committed:
https://chromium.googlesource.com/chromium/src/+/f65aa1847f78fb5a5d944723de97...
==========

[commit-bot: I haz the power, 2017-01-09 21:39:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f65aa1847f78fb5a5d944723de97...