Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2612823003: The great shader refactor: Delete all of the subclasses (Closed)

Created:
3 years, 11 months ago by ccameron
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The great shader refactor: Delete all of the subclasses This changes all (except one) of the program typedefs in GLRenderer to the same type. All of the sub-classes for VertexShaderBase and FragmentShaderBase (except for YUV textures) deleted, and their logic is moved into ProgramBinding::Initialize sub-functions. BUG=667966 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Patch Set 1 #

Patch Set 2 : The great shader refactor: Delete all of the subclasses #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -413 lines) Patch
M cc/output/gl_renderer.h View 1 chunk +23 lines, -54 lines 0 comments Download
M cc/output/gl_renderer.cc View 23 chunks +65 lines, -52 lines 0 comments Download
M cc/output/program_binding.h View 2 chunks +157 lines, -30 lines 0 comments Download
M cc/output/shader.h View 7 chunks +31 lines, -272 lines 0 comments Download
M cc/output/shader.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (5 generated)
ccameron
Description was changed from ========== The great shader refactor: Delete all of the subclasses This ...
3 years, 11 months ago (2017-01-05 08:03:12 UTC) #1
ccameron
The CQ bit was checked by ccameron@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-10 05:49:12 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612823003/20001
3 years, 11 months ago (2017-01-10 05:49:43 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-10 06:56:04 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 06:56:05 UTC) #5
Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

Powered by Google App Engine
This is Rietveld 408576698