The great shader refactor: Prepare to merge all vertex shaders.

The great shader refactor: Prepare to merge all vertex shaders.

Move all uniform locations into a single base class (but leave
configuring them to the sub-classes).

Merge all the head and body of vertex shaders into one segment.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/6ff6e178c890ac2402b6bebb99a6b615b74ea9c9
Cr-Commit-Position: refs/heads/master@{#441496}

[ccameron, 2017-01-04 05:41:54]

Description was changed from

==========
The great shader refactor: Prepare to merge all vertex shaders.

Move all uniform locations into a single base class (but leave
configuring them to the sub-classes).

Merge all the head and body of vertex shaders into one segment.

BUG=667966
==========

to

==========
The great shader refactor: Prepare to merge all vertex shaders.

Move all uniform locations into a single base class (but leave
configuring them to the sub-classes).

Merge all the head and body of vertex shaders into one segment.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-01-04 05:41:57]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 05:42:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 06:54:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 06:54:02]

Dry run: This issue passed the CQ dry run.

[ccameron, 2017-01-04 08:23:52]

Description was changed from

==========
The great shader refactor: Prepare to merge all vertex shaders.

Move all uniform locations into a single base class (but leave
configuring them to the sub-classes).

Merge all the head and body of vertex shaders into one segment.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
The great shader refactor: Prepare to merge all vertex shaders.

Move all uniform locations into a single base class (but leave
configuring them to the sub-classes).

Merge all the head and body of vertex shaders into one segment.

TBR=enne
BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-01-04 08:23:52]

ccameron@chromium.org changed reviewers:
+ enne@chromium.org

[ccameron, 2017-01-04 08:24:56]

TBRing this one because it's mechanical and unlikely to cause bugs.

The next patches will be more error-prone, so I'll want them to be scrutinized
more.

[ccameron, 2017-01-04 08:57:27]

Description was changed from

==========
The great shader refactor: Prepare to merge all vertex shaders.

Move all uniform locations into a single base class (but leave
configuring them to the sub-classes).

Merge all the head and body of vertex shaders into one segment.

TBR=enne
BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
The great shader refactor: Prepare to merge all vertex shaders.

Move all uniform locations into a single base class (but leave
configuring them to the sub-classes).

Merge all the head and body of vertex shaders into one segment.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-01-04 08:57:42]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 08:57:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-01-04 09:06:12]

Err, actually, this ballooned out of control, and so TBR isn't quite appropriate
anymore.

PTAL

The next patch after this will (hopefully) merge all the vertex shaders.

https://codereview.chromium.org/2610803002/diff/20001/cc/output/shader.cc
File cc/output/shader.cc (right):

https://codereview.chromium.org/2610803002/diff/20001/cc/output/shader.cc#new...
cc/output/shader.cc:380: uniform TexCoordPrecision vec4 texTransform;
This is the one instance where I had to edit a shader in this patch.

The issue is that tex_transform_location_ sometimes referred to "texTrans" and
sometimes referred to "texTransformation".

To make this consistent, I changed the instances of "texTrans" to
"texTransform".

https://codereview.chromium.org/2610803002/diff/20001/cc/output/shader.h
File cc/output/shader.h (right):

https://codereview.chromium.org/2610803002/diff/20001/cc/output/shader.h#newc...
cc/output/shader.h:149: 
has_tex_transform_, has_vertex_tex_transform, has_text_matrix, and
has_ya_uv_tex_scale_offset are all mutually-exclusive.

They also have inconsistent meanings (e.g, some refer to arrays to index into,
some are just uniforms).

For now I grouped these together by the _location() accessor function name, to
minimize diffs.

[commit-bot: I haz the power, 2017-01-04 09:57:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 09:57:56]

Dry run: This issue passed the CQ dry run.

[enne (OOO), 2017-01-04 22:09:38]

lgtm

[ccameron, 2017-01-04 22:36:30]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-01-04 22:36:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 22:43:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483569390014980,
"parent_rev": "c98f20f16410b48797d380974211554da9e9c144", "commit_rev":
"a60cea8047827966dc3291e5ed13020087eaa491"}

[commit-bot: I haz the power, 2017-01-04 22:43:31]

Description was changed from

==========
The great shader refactor: Prepare to merge all vertex shaders.

Move all uniform locations into a single base class (but leave
configuring them to the sub-classes).

Merge all the head and body of vertex shaders into one segment.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
The great shader refactor: Prepare to merge all vertex shaders.

Move all uniform locations into a single base class (but leave
configuring them to the sub-classes).

Merge all the head and body of vertex shaders into one segment.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2610803002
==========

[commit-bot: I haz the power, 2017-01-04 22:43:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-04 22:45:31]

Description was changed from

==========
The great shader refactor: Prepare to merge all vertex shaders.

Move all uniform locations into a single base class (but leave
configuring them to the sub-classes).

Merge all the head and body of vertex shaders into one segment.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2610803002
==========

to

==========
The great shader refactor: Prepare to merge all vertex shaders.

Move all uniform locations into a single base class (but leave
configuring them to the sub-classes).

Merge all the head and body of vertex shaders into one segment.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/6ff6e178c890ac2402b6bebb99a6b615b74ea9c9
Cr-Commit-Position: refs/heads/master@{#441496}
==========

[commit-bot: I haz the power, 2017-01-04 22:45:32]

Patchset 2 (id:??) landed as
https://crrev.com/6ff6e178c890ac2402b6bebb99a6b615b74ea9c9
Cr-Commit-Position: refs/heads/master@{#441496}