Bring Aura Window To Front When Sharing

Bring Aura Window To Front When Sharing

When we capture an aura window, namely the chrome window itself, we did
not bring it to the front as we did for other windows.

This CL fixes this issue.

BUG=678436
Review-Url: https://codereview.chromium.org/2617613002
Cr-Commit-Position: refs/heads/master@{#442026}
Committed: https://chromium.googlesource.com/chromium/src/+/233457d015c31a412c1eb01d0bd941601a010861

[qiangchen, 2017-01-05 00:18:52]

Description was changed from

==========
Bring Aura Window To Front When Sharing

BUG=
==========

to

==========
Bring Aura Window To Front When Sharing

When we capture an aura window, namely the chrome window itself, we did
not bring it to the front as we did for other windows.

This CL fixes this issue.

BUG=678436
==========

[qiangchen, 2017-01-05 00:18:52]

qiangchen@chromium.org changed reviewers:
+ msw@chromium.org

[qiangchen, 2017-01-05 00:29:27]

Can you take a look?

[msw, 2017-01-05 01:20:31]

https://codereview.chromium.org/2617613002/diff/1/chrome/browser/ui/views/des...
File chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
(right):

https://codereview.chromium.org/2617613002/diff/1/chrome/browser/ui/views/des...
chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc:343:
Browser* browser = chrome::FindBrowserWithWindow(window);
q: Can we just call window->Activate() instead?

[qiangchen, 2017-01-05 16:34:36]

replied

https://codereview.chromium.org/2617613002/diff/1/chrome/browser/ui/views/des...
File chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
(right):

https://codereview.chromium.org/2617613002/diff/1/chrome/browser/ui/views/des...
chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc:343:
Browser* browser = chrome::FindBrowserWithWindow(window);
On 2017/01/05 01:20:31, msw (vacation jan 4 maybe 5) wrote:
> q: Can we just call window->Activate() instead?

No. aura::Window does not provide such functionality.

Browser->window() is actually an instance of BrowserWindow.

[msw, 2017-01-06 19:11:28]

lgtm

[qiangchen, 2017-01-06 19:15:55]

The CQ bit was checked by qiangchen@chromium.org

[commit-bot: I haz the power, 2017-01-06 19:16:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 20:20:13]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483730155531860, "parent_rev":
"1126746cc1fdb1ec86c564cc1ae03855f8cd66d7", "commit_rev":
"233457d015c31a412c1eb01d0bd941601a010861"}

[commit-bot: I haz the power, 2017-01-06 20:20:43]

Description was changed from

==========
Bring Aura Window To Front When Sharing

When we capture an aura window, namely the chrome window itself, we did
not bring it to the front as we did for other windows.

This CL fixes this issue.

BUG=678436
==========

to

==========
Bring Aura Window To Front When Sharing

When we capture an aura window, namely the chrome window itself, we did
not bring it to the front as we did for other windows.

This CL fixes this issue.

BUG=678436

Review-Url: https://codereview.chromium.org/2617613002
Cr-Commit-Position: refs/heads/master@{#442026}
Committed:
https://chromium.googlesource.com/chromium/src/+/233457d015c31a412c1eb01d0bd9...
==========

[commit-bot: I haz the power, 2017-01-06 20:20:43]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/233457d015c31a412c1eb01d0bd9...