Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc

Issue 2617613002: Bring Aura Window To Front When Sharing (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
diff --git a/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc b/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
index d5bd2410732945710162e963ed0da03b3de58447..191d850fe3ee1f9f1952db0dab0cc3a9c65888b8 100644
--- a/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
+++ b/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
@@ -337,6 +337,13 @@ bool DesktopMediaPickerDialogView::Accept() {
if (browser && browser->window())
browser->window()->Activate();
}
+ } else if (source.type == DesktopMediaID::TYPE_WINDOW) {
+#if defined(USE_AURA)
+ aura::Window* window = DesktopMediaID::GetAuraWindowById(source);
+ Browser* browser = chrome::FindBrowserWithWindow(window);
msw 2017/01/05 01:20:31 q: Can we just call window->Activate() instead?
qiangchen 2017/01/05 16:34:36 No. aura::Window does not provide such functionali
+ if (browser && browser->window())
+ browser->window()->Activate();
+#endif
}
if (parent_)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698