Bring Aura Window To Front When Sharing

chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.h"
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "chrome/browser/media/webrtc/desktop_media_list.h"
 #include "chrome/browser/ui/browser_finder.h"
@@ skipping 319 matching lines @@
     content::WebContents* tab = content::WebContents::FromRenderFrameHost(
         content::RenderFrameHost::FromID(
             source.web_contents_id.render_process_id,
             source.web_contents_id.main_render_frame_id));
     if (tab) {
       tab->GetDelegate()->ActivateContents(tab);
       Browser* browser = chrome::FindBrowserWithWebContents(tab);
       if (browser && browser->window())
         browser->window()->Activate();
     }
+  } else if (source.type == DesktopMediaID::TYPE_WINDOW) {
+#if defined(USE_AURA)
+    aura::Window* window = DesktopMediaID::GetAuraWindowById(source);
+    Browser* browser = chrome::FindBrowserWithWindow(window);

[msw, 2017/01/05 01:20:31]

q: Can we just call window->Activate() instead?

[qiangchen, 2017/01/05 16:34:36]

No. aura::Window does not provide such functionality.

Browser->window() is actually an instance of BrowserWindow.

+    if (browser && browser->window())
+      browser->window()->Activate();
+#endif
   }
 
   if (parent_)
     parent_->NotifyDialogResult(source);
 
   // Return true to close the window.
   return true;
 }
 
 void DesktopMediaPickerDialogView::DeleteDelegate() {
@@ skipping 95 matching lines @@
 
 // static
 std::unique_ptr<DesktopMediaPicker> DesktopMediaPicker::Create() {
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           extensions::switches::kDisableDesktopCapturePickerNewUI)) {
     return std::unique_ptr<DesktopMediaPicker>(
         new deprecated::DesktopMediaPickerViews());
   }
   return std::unique_ptr<DesktopMediaPicker>(new DesktopMediaPickerViews());
 }