Use a new Supplement construtor in PagePopupController

Use a new Supplement construtor in PagePopupController

We're deprecating the default constructor of Supplement.

This CL also refactors PagePopupSupplement to make the implementation
closer to other supplement implementations.

BUG=610176
Review-Url: https://codereview.chromium.org/2617113003
Cr-Commit-Position: refs/heads/master@{#441949}
Committed: https://chromium.googlesource.com/chromium/src/+/a7d691668d850776763dc437d808fadfb4b3154d

[haraken, 2017-01-06 12:00:22]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com

[haraken, 2017-01-06 12:00:23]

PTAL

[haraken, 2017-01-06 12:01:04]

The CQ bit was checked by haraken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 12:01:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-01-06 12:01:36]

https://codereview.chromium.org/2617113003/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp
(right):

https://codereview.chromium.org/2617113003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp:39:
void V8PagePopupControllerBinding::installPagePopupController(

BTW, this binding is doing very weird things...

[sof, 2017-01-06 12:09:11]

lgtm

https://codereview.chromium.org/2617113003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/page/PagePopupSupplement.h (right):

https://codereview.chromium.org/2617113003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/page/PagePopupSupplement.h:55: void dispose();
nit: make dispose() private?

[haraken, 2017-01-06 12:47:45]

On 2017/01/06 12:09:11, sof wrote:
> lgtm
> 
>
https://codereview.chromium.org/2617113003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/page/PagePopupSupplement.h (right):
> 
>
https://codereview.chromium.org/2617113003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/page/PagePopupSupplement.h:55: void dispose();
> nit: make dispose() private?

Done.

[haraken, 2017-01-06 12:47:59]

The CQ bit was checked by haraken@chromium.org

[haraken, 2017-01-06 12:47:59]

The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/2617113003/#ps20001
(title: "temp")

[commit-bot: I haz the power, 2017-01-06 12:48:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 14:40:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 14:40:44]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haraken, 2017-01-06 14:47:18]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2017-01-06 14:47:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 16:37:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483714038609030,
"parent_rev": "67a34aac120086ec558e92fa87c2f401b14726fe", "commit_rev":
"a7d691668d850776763dc437d808fadfb4b3154d"}

[commit-bot: I haz the power, 2017-01-06 16:37:48]

Description was changed from

==========
Use a new Supplement construtor in PagePopupController

We're deprecating the default constructor of Supplement.

This CL also refactors PagePopupSupplement to make the implementation
closer to other supplement implementations.

BUG=610176
==========

to

==========
Use a new Supplement construtor in PagePopupController

We're deprecating the default constructor of Supplement.

This CL also refactors PagePopupSupplement to make the implementation
closer to other supplement implementations.

BUG=610176

Review-Url: https://codereview.chromium.org/2617113003
Cr-Commit-Position: refs/heads/master@{#441949}
Committed:
https://chromium.googlesource.com/chromium/src/+/a7d691668d850776763dc437d808...
==========

[commit-bot: I haz the power, 2017-01-06 16:37:49]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a7d691668d850776763dc437d808...