Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp

Issue 2617113003: Use a new Supplement construtor in PagePopupController (Closed)
Patch Set: temp Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/page/PagePopupSupplement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp
index e6d1e5772cc80a526c67b01d0a9ec7cc22451327..f6afc329eb8e50286fd3addb4915adc998c65ced 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp
@@ -22,8 +22,9 @@ void pagePopupControllerAttributeGetter(
const v8::PropertyCallbackInfo<v8::Value>& info) {
v8::Local<v8::Object> holder = info.Holder();
DOMWindow* impl = V8Window::toImpl(holder);
- PagePopupController* cppValue = PagePopupSupplement::pagePopupController(
- *toLocalDOMWindow(impl)->frame());
+ PagePopupController* cppValue =
+ PagePopupSupplement::from(*toLocalDOMWindow(impl)->frame())
+ .pagePopupController();
v8SetReturnValue(info, ToV8(cppValue, holder, info.GetIsolate()));
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/page/PagePopupSupplement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698