third_party/WebKit/Source/core/page/PagePopupSupplement.h - Issue 2617113003: Use a new Supplement construtor in PagePopupController

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/page/PagePopupSupplement.h

Issue 2617113003: Use a new Supplement construtor in PagePopupController (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp ('k') | third_party/WebKit/Source/core/page/PagePopupSupplement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2012 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 30 matching lines...) Expand all Loading...
41 class PagePopup;	41 class PagePopup;

42 class PagePopupClient;	42 class PagePopupClient;

43 class PagePopupController;	43 class PagePopupController;

44	44

45 class CORE_EXPORT PagePopupSupplement final	45 class CORE_EXPORT PagePopupSupplement final

46 : public GarbageCollected<PagePopupSupplement>,	46 : public GarbageCollected<PagePopupSupplement>,

47 public Supplement<LocalFrame> {	47 public Supplement<LocalFrame> {

48 USING_GARBAGE_COLLECTED_MIXIN(PagePopupSupplement);	48 USING_GARBAGE_COLLECTED_MIXIN(PagePopupSupplement);

49	49

50 public:	50 public:

51 static PagePopupController* pagePopupController(LocalFrame&);	51 static PagePopupSupplement& from(LocalFrame&);

52 static void install(LocalFrame&, PagePopup&, PagePopupClient*);	52 static void install(LocalFrame&, PagePopup&, PagePopupClient*);

53 static void uninstall(LocalFrame&);	53 static void uninstall(LocalFrame&);

	54

	55 void dispose();
	sof 2017/01/06 12:09:11 nit: make dispose() private? nit: make dispose() private?
	56 PagePopupController* pagePopupController() const;

54 DECLARE_TRACE();	57 DECLARE_TRACE();

55	58

56 private:	59 private:

57 PagePopupSupplement(PagePopup&, PagePopupClient*);	60 PagePopupSupplement(LocalFrame&, PagePopup&, PagePopupClient*);

58 static const char* supplementName();	61 static const char* supplementName();

59	62

60 Member<PagePopupController> m_controller;	63 Member<PagePopupController> m_controller;

61 };	64 };

62	65

63 } // namespace blink	66 } // namespace blink

64 #endif	67 #endif

OLD	NEW