Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 2617073002: Additional DCHECKs when accessing SharedArrayBuffer (Closed)

Created:
3 years, 11 months ago by binji
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Additional DCHECKs when accessing SharedArrayBuffer This change makes wtf::ArrayBuffer::data() require that the underlying ArrayBuffer be non-shared. The caller must use dataShared() or dataMaybeShared() to access the underlying data of a SharedArrayBuffer. BUG=678410 Review-Url: https://codereview.chromium.org/2617073002 Cr-Commit-Position: refs/heads/master@{#443472} Committed: https://chromium.googlesource.com/chromium/src/+/8a78ba792d40259446b67f8f484911642f552ee6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -11 lines) Patch
M third_party/WebKit/Source/core/dom/DOMSharedArrayBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.h View 5 chunks +24 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferContents.h View 1 chunk +11 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferView.h View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferView.cpp View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
binji
3 years, 11 months ago (2017-01-07 00:53:47 UTC) #6
haraken
LGTM
3 years, 11 months ago (2017-01-07 01:23:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617073002/1
3 years, 11 months ago (2017-01-13 00:18:47 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 02:24:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8a78ba792d40259446b67f8f4849...

Powered by Google App Engine
This is Rietveld 408576698