third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferView.h - Issue 2617073002: Additional DCHECKs when accessing SharedArrayBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferView.h

Issue 2617073002: Additional DCHECKs when accessing SharedArrayBuffer (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferView.h

diff --git a/third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferView.h b/third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferView.h

index 6b22f5f89f17f6d492f0454a910a8155dd33629d..61689039b01ae54b32aa6900c4619631c9047906 100644

--- a/third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferView.h

+++ b/third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferView.h

@@ -54,7 +54,10 @@ class WTF_EXPORT ArrayBufferView : public RefCounted<ArrayBufferView> {

ArrayBuffer* buffer() const { return m_buffer.get(); }

- void* baseAddress() const { return m_baseAddress; }

+ void* baseAddress() const {

+ DCHECK(!isShared());

+ return m_baseAddress;

+ }

unsigned byteOffset() const { return m_byteOffset; }