third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.cpp - Issue 2617073002: Additional DCHECKs when accessing SharedArrayBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.cpp

Issue 2617073002: Additional DCHECKs when accessing SharedArrayBuffer (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.cpp

diff --git a/third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.cpp b/third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.cpp

index c9d6777adb38cf11cece1a904c07cf5f5ccbcb5f..c2979d84c0613e30bc0b04c7b5e37cc092c76b56 100644

--- a/third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.cpp

+++ b/third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.cpp

@@ -69,7 +69,7 @@ bool ArrayBuffer::shareContentsWith(ArrayBufferContents& result) {

DCHECK(isShared());

RefPtr<ArrayBuffer> keepAlive(this);

- if (!m_contents.data()) {

+ if (!m_contents.dataShared()) {

result.neuter();

return false;

}