Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2616353003: Clarify property tree id-to-index map names. (Closed)

Created:
3 years, 11 months ago by wkorman
Modified:
3 years, 11 months ago
Reviewers:
ajuma, chrishtr
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clarify property tree id-to-index map names. Follow-up from discussion on http://crrev.com/2612093002. BUG=674258 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2616353003 Cr-Commit-Position: refs/heads/master@{#443027} Committed: https://chromium.googlesource.com/chromium/src/+/c2d1f65f2eaf620936ed56c42fe3e6235674600b

Patch Set 1 #

Total comments: 4

Patch Set 2 : Wrap comments. #

Patch Set 3 : Rename in PaintArtifactCompositor. #

Patch Set 4 : Sync to head. #

Patch Set 5 : Sync to head. #

Patch Set 6 : Sync to head. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -117 lines) Patch
M cc/input/scrollbar_animation_controller_linear_fade.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M cc/input/scrollbar_animation_controller_thinning.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M cc/layers/layer.cc View 10 chunks +13 lines, -11 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 2 4 chunks +8 lines, -8 lines 0 comments Download
M cc/layers/render_surface_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 3 1 chunk +43 lines, -34 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/property_tree.h View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M cc/trees/property_tree.cc View 1 2 3 5 chunks +26 lines, -24 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 1 2 3 4 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 1 2 8 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 48 (28 generated)
wkorman
Makes these more self-documenting and in line with names in http://crrev.com/2612093002.
3 years, 11 months ago (2017-01-10 00:21:23 UTC) #3
ajuma
lgtm https://codereview.chromium.org/2616353003/diff/1/cc/input/scrollbar_animation_controller_linear_fade.cc File cc/input/scrollbar_animation_controller_linear_fade.cc (right): https://codereview.chromium.org/2616353003/diff/1/cc/input/scrollbar_animation_controller_linear_fade.cc#newcode67 cc/input/scrollbar_animation_controller_linear_fade.cc:67: // are nit: needs re-wrapping https://codereview.chromium.org/2616353003/diff/1/cc/input/scrollbar_animation_controller_thinning.cc File cc/input/scrollbar_animation_controller_thinning.cc ...
3 years, 11 months ago (2017-01-10 00:51:44 UTC) #4
wkorman
https://codereview.chromium.org/2616353003/diff/1/cc/input/scrollbar_animation_controller_linear_fade.cc File cc/input/scrollbar_animation_controller_linear_fade.cc (right): https://codereview.chromium.org/2616353003/diff/1/cc/input/scrollbar_animation_controller_linear_fade.cc#newcode67 cc/input/scrollbar_animation_controller_linear_fade.cc:67: // are On 2017/01/10 at 00:51:44, ajuma wrote: > ...
3 years, 11 months ago (2017-01-10 01:13:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616353003/20001
3 years, 11 months ago (2017-01-10 01:14:51 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/builds/3340)
3 years, 11 months ago (2017-01-10 01:34:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616353003/40001
3 years, 11 months ago (2017-01-10 20:56:17 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/338726)
3 years, 11 months ago (2017-01-10 21:04:48 UTC) #15
wkorman
+chrishtr for Blink platform OWNERS. Just a field rename.
3 years, 11 months ago (2017-01-10 21:08:21 UTC) #17
chrishtr
lgtm
3 years, 11 months ago (2017-01-10 21:15:51 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616353003/60001
3 years, 11 months ago (2017-01-10 23:26:05 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/97380)
3 years, 11 months ago (2017-01-11 00:26:34 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616353003/60001
3 years, 11 months ago (2017-01-11 03:23:38 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/339141)
3 years, 11 months ago (2017-01-11 03:30:21 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616353003/80001
3 years, 11 months ago (2017-01-11 04:06:20 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/97760)
3 years, 11 months ago (2017-01-11 05:39:49 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616353003/80001
3 years, 11 months ago (2017-01-11 07:28:24 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/97880)
3 years, 11 months ago (2017-01-11 08:34:30 UTC) #41
wkorman
Filed http://crbug.com/680254 to track apparent issue with the Android swarming build, but going to try ...
3 years, 11 months ago (2017-01-11 21:09:26 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616353003/100001
3 years, 11 months ago (2017-01-11 21:10:08 UTC) #45
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 22:46:14 UTC) #48
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/c2d1f65f2eaf620936ed56c42fe3...

Powered by Google App Engine
This is Rietveld 408576698