Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2615633005: Mojo JS bindings: remove usage of the connection module. (Closed)

Created:
3 years, 11 months ago by yzshen1
Modified:
3 years, 11 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo JS bindings: remove usage of the connection module. BUG=579646 Committed: https://crrev.com/4cbc282a724bad6fb6dec8b3ed0f455219149d10 Cr-Commit-Position: refs/heads/master@{#441539}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -104 lines) Patch
M mojo/public/js/bindings.js View 1 10 chunks +47 lines, -37 lines 0 comments Download
M mojo/public/js/connector.js View 1 2 chunks +8 lines, -19 lines 0 comments Download
M mojo/public/js/router.js View 1 6 chunks +38 lines, -14 lines 0 comments Download
M mojo/public/js/validation_unittests.js View 1 3 chunks +17 lines, -26 lines 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl View 2 chunks +3 lines, -6 lines 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl View 1 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (13 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
3 years, 11 months ago (2017-01-04 23:21:25 UTC) #7
Ken Rockot(use gerrit already)
lgtm!
3 years, 11 months ago (2017-01-05 00:42:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615633005/20001
3 years, 11 months ago (2017-01-05 00:59:22 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-05 01:05:27 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 01:07:02 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4cbc282a724bad6fb6dec8b3ed0f455219149d10
Cr-Commit-Position: refs/heads/master@{#441539}

Powered by Google App Engine
This is Rietveld 408576698