Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 2608383002: Mojo JS bindings: switch mock-vr-service to use the new bindings API. (Closed)

Created:
3 years, 11 months ago by yzshen1
Modified:
3 years, 11 months ago
Reviewers:
bsheedy, Lei Lei
CC:
chromium-reviews, blink-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo JS bindings: switch mock-vr-service to use the new bindings API. BUG=675325, 579646 Committed: https://crrev.com/ff31402128fbd9140bdedf4b4a7e809551847f33 Cr-Commit-Position: refs/heads/master@{#441265}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -29 lines) Patch
M third_party/WebKit/LayoutTests/vr/resources/mock-vr-service.js View 3 chunks +17 lines, -29 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
yzshen1
Hi, reviewers. Would you please take a look? Thanks!
3 years, 11 months ago (2017-01-03 23:06:07 UTC) #4
bsheedy
On 2017/01/03 23:06:07, yzshen1 wrote: > Hi, reviewers. > > Would you please take a ...
3 years, 11 months ago (2017-01-03 23:12:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608383002/1
3 years, 11 months ago (2017-01-03 23:13:38 UTC) #8
Lei Lei
lgtm
3 years, 11 months ago (2017-01-03 23:40:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 00:26:53 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 00:30:14 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff31402128fbd9140bdedf4b4a7e809551847f33
Cr-Commit-Position: refs/heads/master@{#441265}

Powered by Google App Engine
This is Rietveld 408576698