Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Issue 2616493005: Mojo JS bindings: remove the connection module. (Closed)

Created:
3 years, 11 months ago by yzshen1
Modified:
3 years, 11 months ago
Reviewers:
jam
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, lcwu+watch_chromium.org, jam, extensions-reviews_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, halliwell+watch_chromium.org, chromium-apps-reviews_chromium.org, alokp+watch_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo JS bindings: remove the connection module. It is not used by anyone anymore. BUG=579646

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -307 lines) Patch
M chromecast/renderer/cast_content_renderer_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/mojo_context_state.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/dispatcher.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/web/ios_web_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/webui/crw_web_ui_manager.mm View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/js/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/public/js/connection.js View 1 chunk +0 lines, -297 lines 0 comments Download
M mojo/public/js/constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/js/constants.cc View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
yzshen1
Hi, John. Would you please take a look? Thanks!
3 years, 11 months ago (2017-01-04 23:31:22 UTC) #4
jam
lgtm
3 years, 11 months ago (2017-01-05 16:08:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616493005/1
3 years, 11 months ago (2017-01-05 16:26:06 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 16:36:52 UTC) #12
Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

Powered by Google App Engine
This is Rietveld 408576698