Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 261553002: Revert of Move DefaultActivationClient to wm/core (Closed)

Created:
6 years, 7 months ago by robliao
Modified:
6 years, 7 months ago
CC:
chromium-reviews, ben+aura_chromium.org, yusukes+watch_chromium.org, viettrungluu+watch_chromium.org, sievers+watch_chromium.org, yukishiino+watch_chromium.org, dmazzoni+watch_chromium.org, sadrul, ben+mojo_chromium.org, miu+watch_chromium.org, aboxhall+watch_chromium.org, jam, abarth-chromium, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, penghuang+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, piman+watch_chromium.org, darin (slow to review), jochen+watch_chromium.org, plundblad+watch_chromium.org, tfarina, Aaron Boodman, dtseng+watch_chromium.org, danakj+watch_chromium.org, James Su, awong
Visibility:
Public.

Description

Revert of Move DefaultActivationClient to wm/core (https://codereview.chromium.org/250113002/) Reason for revert: views_unittest TooltipController test failures views_unittests views_unittests 4 disabled 10 flaky failed 10 ( 9 secs ) stdio Capture CloseOnCaptureLost DontShowEmptyTooltips EnableOrDisableTooltips HideOnExit ReshowOnClickAfterEnterExit TooltipHidesOnKeyPressAndStaysHiddenUntilChange TooltipHidesOnTimeoutAndStaysHiddenUntilChange TooltipsInMultipleViews ViewTooltip TooltipControllerTest.ViewTooltip (run #2): [ RUN ] TooltipControllerTest.ViewTooltip Xlib: extension "RANDR" missing on display ":9". Received signal 11 SEGV_MAPERR 000000000000 #0 0x000000a88e4e base::debug::StackTrace::StackTrace() #1 0x000000a89068 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f9474270cb0 \u003Cunknown> #3 0x000000736b83 views::NativeWidgetAura::Activate() #4 0x000000737508 views::NativeWidgetAura::ShowWithWindowState() #5 0x000000738acb views::Widget::Show() #6 0x00000052cb09 views::corewm::test::(anonymous namespace)::CreateWidget() #7 0x00000052d397 views::corewm::test::TooltipControllerTest::SetUp() #8 0x00000065a16a testing::Test::Run(). Original issue's description: > Move DefaultActivationClient to wm/core > > Several tests are using AuraTestHelper and were relying on it to set up the DefaultActivationClient, so I had to have them instantiate the DAC directly after calling SetUp() on the helper. I also had to make the DAC delete itself after the root window it's bound to is destroyed. > > R=sky@chromium.org > http://crbug.com/308710 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266616 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266975 TBR=sky@chromium.org,ben@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267001

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -273 lines) Patch
M chrome/browser/ui/views/accessibility/accessibility_event_router_views_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/apps/shaped_app_window_targeter_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/base/view_event_test_base.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/test/test_renderer_host.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/shell/browser/shell_platform_data_aura.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/shell/browser/shell_platform_data_aura.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/examples/launcher/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/examples/launcher/launcher.cc View 4 chunks +4 lines, -2 lines 0 comments Download
M mojo/mojo_examples.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/aura.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A ui/aura/client/default_activation_client.h View 1 chunk +69 lines, -0 lines 0 comments Download
A ui/aura/client/default_activation_client.cc View 1 chunk +128 lines, -0 lines 0 comments Download
M ui/aura/test/aura_test_helper.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/aura/test/aura_test_helper.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M ui/keyboard/keyboard.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/keyboard/keyboard_controller_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/snapshot/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ui/snapshot/snapshot.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/snapshot/snapshot_aura_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/views/test/views_test_base.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/wm/core/compound_event_filter_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D ui/wm/core/default_activation_client.h View 1 chunk +0 lines, -73 lines 0 comments Download
D ui/wm/core/default_activation_client.cc View 1 chunk +0 lines, -157 lines 0 comments Download
M ui/wm/core/input_method_event_filter_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/wm/core/shadow_controller_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/wm/test/wm_test_helper.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/wm/test/wm_test_helper.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/wm/wm.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robliao
Created Revert of Move DefaultActivationClient to wm/core
6 years, 7 months ago (2014-04-30 00:09:22 UTC) #1
robliao
6 years, 7 months ago (2014-04-30 00:09:40 UTC) #2
robliao
The CQ bit was checked by robliao@chromium.org
6 years, 7 months ago (2014-04-30 00:09:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robliao@chromium.org/261553002/1
6 years, 7 months ago (2014-04-30 00:11:35 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 00:14:08 UTC) #5
Message was sent while issue was closed.
Change committed as 267001

Powered by Google App Engine
This is Rietveld 408576698