ios/chrome/browser/downstream_chromium_browser_provider.h - Issue 2615433002: Remove ChromeBrowserProvider::IsOffTheRecordSessionActive().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/downstream_chromium_browser_provider.h

Issue 2615433002: Remove ChromeBrowserProvider::IsOffTheRecordSessionActive(). (Closed)

Patch Set: Address comment. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/downstream_chromium_browser_provider.h

diff --git a/ios/chrome/browser/downstream_chromium_browser_provider.h b/ios/chrome/browser/downstream_chromium_browser_provider.h

index 9f8e139e6981da09ef6950215d70c38c312791d8..2e1e189cbbd42aad20b8d25e244bc23f134d2847 100644

--- a/ios/chrome/browser/downstream_chromium_browser_provider.h

+++ b/ios/chrome/browser/downstream_chromium_browser_provider.h

@@ -19,7 +19,6 @@ class DownstreamChromiumBrowserProvider : public ChromiumBrowserProvider {

// ChromeBrowserProvider implementations. All of these will move upstream

// into ChromiumBrowserProvider eventually, and from there callers will be

// converted to not go through the provider API at all.

- bool IsOffTheRecordSessionActive() override;

void GetFaviconForURL(

ios::ChromeBrowserState* browser_state,

const GURL& page_url,