Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2614773004: [cleanup] Refactor builtins-math.cc to use TF_BUILTIN macro (Closed)

Created:
3 years, 11 months ago by Jakob Kummerow
Modified:
3 years, 11 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Refactor builtins-math.cc to use TF_BUILTIN macro Review-Url: https://codereview.chromium.org/2614773004 Cr-Commit-Position: refs/heads/master@{#42135} Committed: https://chromium.googlesource.com/v8/v8/+/fab14341f508c2260d5640608d6d035e335e5ca4

Patch Set 1 : no formatting #

Patch Set 2 : formatted #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -301 lines) Patch
M src/builtins/builtins-math.cc View 1 2 chunks +226 lines, -301 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Jakob Kummerow
Moar of that :-)
3 years, 11 months ago (2017-01-09 09:45:55 UTC) #2
jgruber
lgtm
3 years, 11 months ago (2017-01-09 09:58:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614773004/20001
3 years, 11 months ago (2017-01-09 10:17:57 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 10:20:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/fab14341f508c2260d5640608d6d035e335...

Powered by Google App Engine
This is Rietveld 408576698