Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 2614013003: Remove IgnorableExceptionState (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
slangley, Yuki
CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove IgnorableExceptionState IgnorableExceptionState is equivalent to DummyExceptionStateForTesting. We should just use DummyExceptionStateForTesting. BUG= Review-Url: https://codereview.chromium.org/2614013003 Cr-Commit-Position: refs/heads/master@{#441871} Committed: https://chromium.googlesource.com/chromium/src/+/7254e3507c46f8b090662342ec71ccd36da468c5

Patch Set 1 #

Patch Set 2 : temp #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -24 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ExceptionState.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.h View 1 2 chunks +3 lines, -22 lines 2 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
haraken
PTAL https://codereview.chromium.org/2614013003/diff/20001/third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.h File third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.h (right): https://codereview.chromium.org/2614013003/diff/20001/third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.h#newcode41 third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.h:41: #define IGNORE_EXCEPTION (::blink::DummyExceptionStateForTesting().returnThis()) I noticed that we should ...
3 years, 11 months ago (2017-01-06 00:52:53 UTC) #2
slangley
lgtm
3 years, 11 months ago (2017-01-06 01:07:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614013003/20001
3 years, 11 months ago (2017-01-06 01:32:51 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/7254e3507c46f8b090662342ec71ccd36da468c5
3 years, 11 months ago (2017-01-06 04:15:37 UTC) #8
Yuki
3 years, 11 months ago (2017-01-06 06:39:16 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698